Skip to content

London | 26-ITP-Sep | Diana Ausiejute | Sprint 1 | Format clock edge cases #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ausiejute wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep | Diana Ausiejute | Sprint 1 | Format clock edge cases #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5225f24
Add minutes variable and write a test to check it
ausiejute Oct 5, 2026
2fa8c14
Write tests for hours before midnight and midday
ausiejute Oct 5, 2026
d136f28
Write a test and change code to correctly convert midnight
ausiejute Oct 5, 2026
6891773
Write a test and change code to correctly convert midday hours
ausiejute Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3, 5);

if (hours > 12) {
return `${hours - 12}:00 pm`;
if (hours === 0) {
return `12:${minutes} am`;
} else if (hours === 12) {
return `12:${minutes} pm`;
} else if (hours > 12) {
const pmHours = (hours - 12).toString().padStart(2, "0");
return `${pmHours}:${minutes} pm`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
25 changes: 20 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,26 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("can correctly convert minutes", () =>
assert.equal(formatAs12HourClock("13:30"), "01:30 pm"));

test("can correctly convert hours before midnight", () =>
assert.equal(formatAs12HourClock("23:59"), "11:59 pm"));

test("can correctly convert hours before midday", () =>
assert.equal(formatAs12HourClock("11:59"), "11:59 am"));

test("can correctly convert midnight", () =>
assert.equal(formatAs12HourClock("00:00"), "12:00 am"));

test("can correctly convert midday", () =>
assert.equal(formatAs12HourClock("12:00"), "12:00 pm"));
Loading