build(deps): bump windows from 0.58.0 to 0.62.2 - #80
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [windows](https://github.com/microsoft/windows-rs) from 0.58.0 to 0.62.2. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows dependency-version: 0.62.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryThe Windows dependency upgrade to Confidence Score: 4/5Not safe to merge: the Windows-targeted sandbox build is currently broken. A reproducible Windows compilation failure prevents affected users from building the CLI. Files Needing Attention:
|
|
|
||
| [target.'cfg(windows)'.dependencies] | ||
| windows = { version = "0.58", features = [ | ||
| windows = { version = "0.62", features = [ |
There was a problem hiding this comment.
Updating this dependency resolves windows to 0.62.2, but src/cortex-windows-sandbox/src/job.rs:223 still passes a bare HANDLE to QueryInformationJobObject. That API now requires Option<HANDLE>, so the Windows-targeted sandbox build fails and Windows users cannot build the CLI from this revision. Update the call to pass Some(self.handle) before merging.
Artifacts
- The executable script records and runs the exact pinned-toolchain cargo check from the repository root, providing the reproducible source of the validation.
- The captured command output shows the focused x86_64-pc-windows-gnu check exited 101 because job.rs passes HANDLE where windows 0.62.2 requires Option<HANDLE>, confirming the build-breaking incompatibility.
Bumps windows from 0.58.0 to 0.62.2.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)