Skip to content

build(deps): bump windows from 0.58.0 to 0.62.2 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −56
Open

build(deps): bump windows from 0.58.0 to 0.62.2 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 41 additions & 54 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/cortex-sandbox/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ libc = { workspace = true }
libc = { workspace = true }

[target.'cfg(target_os = "windows")'.dependencies]
windows = { version = "0.58", features = [
windows = { version = "0.62", features = [
"Win32_Foundation",
"Win32_Security",
"Win32_Security_Authorization",
Expand Down
2 changes: 1 addition & 1 deletion src/cortex-windows-sandbox/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ rust-version.workspace = true
description = "Windows sandbox support for Cortex CLI"

[target.'cfg(windows)'.dependencies]
windows = { version = "0.58", features = [
windows = { version = "0.62", features = [

@greptile-apps greptile-apps Bot Sep 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Windows sandbox build fails

Updating this dependency resolves windows to 0.62.2, but src/cortex-windows-sandbox/src/job.rs:223 still passes a bare HANDLE to QueryInformationJobObject. That API now requires Option<HANDLE>, so the Windows-targeted sandbox build fails and Windows users cannot build the CLI from this revision. Update the call to pass Some(self.handle) before merging.

Artifacts

Evidence from the check

  • The executable script records and runs the exact pinned-toolchain cargo check from the repository root, providing the reproducible source of the validation.

Command output from the check

  • The captured command output shows the focused x86_64-pc-windows-gnu check exited 101 because job.rs passes HANDLE where windows 0.62.2 requires Option<HANDLE>, confirming the build-breaking incompatibility.

View artifacts

T-Rex Ran code and verified through T-Rex

"Win32_Foundation",
"Win32_Security",
"Win32_Security_Authorization",
Expand Down
Loading