Repository navigation
Tooling: 3.58× faster joint-frame product with identical receipts - #1922
Open
VictorLiwentao wants to merge 2 commits into
Open
VictorLiwentao wants to merge 2 commits into
VictorLiwentao wants to merge 2 commits into
Conversation
Clear denominators once per factor in audit_joint_frames.product, multiply with Python integers, and rebuild canonical Fractions. Positive-side experiment receipts stay fieldwise identical; only the rank-product certificate pin for audit_joint_frames.py changes.
This was referenced Oct 14, 2026
Contributor
|
The scoped differential suite passes: 2,500 positive-shape products, the historical stream, source/certificate checks and 12 unit tests. I found one small legacy behavior regression before production integration: |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change and scope
At base
0b1cccf86e2f5132ed286a26ef0a681a495740ea, the historical positive-side audit spends substantial time inscripts/audit_joint_frames.py:product, which multiplies rational matrices entrywise with many intermediateFractions.This PR clears denominators once per factor, multiplies with Python integers, and rebuilds canonical
Fractions. The product is entrywise equivalent. Only the source pin foraudit_joint_frames.pychanges insidecertificates/rank-product-core.json.Tooling improvement; no new kappa. Selected frontier untouched.
Result
On Linux / CPython 3.12, five alternating fresh-process pairs of the positive-side stream gave median 26.143 → 7.302 s (3.58×). Timing is host-descriptive and is not a correctness gate. Positive-side experiment receipts stay fieldwise identical.
Package:
research/joint-frames-cleared-product/.Validation
Expected:
Default verify is read-only. Full
make verify, selected cold replay, Lean, and multiplication-theorem obligations were not rerun for this isolated historical-checker change.Overlap and credit
Closest priors (different objects): CrocSwap/integer-mult-bounds#756, CrocSwap/integer-mult-bounds#1793, CrocSwap/integer-mult-bounds#1861, CrocSwap/integer-mult-bounds#1217. No competing open PR on cleared-denominator
productat refresh.Predecessor joint-frame / positive-side checker authors retain credit. Prepared by Wentao Li (VictorLiwentao, @Is__Victor) with substantial AI assistance, under Apache-2.0.