Repository navigation
Conversation
#182 and #186 both added a migration at 20261016200000. The runner keys crove_meta.schema_migrations by version, so every fresh install (compose, the CI db job, the invariant suite) stops at the second file with "duplicate key value violates unique constraint schema_migrations_pkey". #186's file sorts second, so no database can have applied it under 20261016200000; it moves to 20261016200100 unchanged. A unit test now fails CI when two migration files share a version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013LrvuThKGaPX1uDwUiwmGQ
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new test suite in tools/test/migration-versions.test.ts to verify that all Supabase migration files have unique 14-digit version prefixes. Feedback suggests enhancing this test to validate the entire filename against the strict naming convention pattern used by the migration runner, which would prevent runtime migration failures and allow for cleaner, safer TypeScript code.
… rule A misnamed file now fails the unit test without a database, before the runner rejects it at migrate time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013LrvuThKGaPX1uDwUiwmGQ
Problem
mainis broken for every fresh install. #182 (20261016200000_crove_kernel_inbound_drop_count.sql) and #186 (20261016200000_crove_kernel_session_revoke_rank_revoked.sql) share a version. The runner keyscrove_meta.schema_migrationsby version, so applying migrations stops at the second file:This breaks
docker compose up(themigrateservice exits 1), the CIdbjob and the invariant suite onmainat10b21d7. I reproduced it locally withvitest run --project db.Fix
20261016200000_crove_kernel_session_revoke_rank_revoked.sql→20261016200100_..., content unchanged.20261016200000.tools/test/migration-versions.test.ts: a unit test that fails when two files insupabase/migrationsshare a 14-digit version. I checked that it fails onmain's layout and passes after the rename.Tests
Local, on
mainat10b21d7plus this change, PostgreSQL 17:pnpm lint,pnpm typecheckandpnpm docs:checkpass.Touches
supabase/migrations/(a protected path), so the invariant job from the base runs. Because the base itself cannot migrate, that job may fail until this merges. It is not the PR's own failure.🤖 Generated with Claude Code
https://claude.ai/code/session_013LrvuThKGaPX1uDwUiwmGQ
Generated by Claude Code
Summary by CodeRabbit