Skip to content

NBK-175: remove redundant DDSQL time-series command - #787

Draft
nmuldavin wants to merge 2 commits into
DataDog:mainfrom
nmuldavin:noah.muldavin/nbk-175-pup-remove-ddsql-time-series
Draft

NBK-175: remove redundant DDSQL time-series command#787
nmuldavin wants to merge 2 commits into
DataDog:mainfrom
nmuldavin:noah.muldavin/nbk-175-pup-remove-ddsql-time-series

Conversation

@nmuldavin

@nmuldavin nmuldavin commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Linear

NBK-175 — https://linear.app/datadoghq/issue/NBK-175/pup-remove-ddsql-time-series

Outcome

pup ddsql time-series is hard-removed. Remaining examples use the general pup ddsql table command without prescribing a migration-specific row limit.

Scope

  • Remove the redundant clap variant, dispatch arm, implementation, and parity-harness entry.
  • Replace the stale positive parse test with a negative unknown-subcommand regression test.
  • Remove the command from DDSQL help and command documentation.
  • Keep the NBK-161 public v2 execution implementation unchanged; this branch is stacked on PR NBK-161: migrate DDSQL execution to public v2 API #785.

Acceptance

  • pup ddsql time-series exits 2 with a clear unrecognized subcommand 'time-series' error.
  • Remaining DDSQL examples use pup ddsql table without prescribing a migration-specific row limit.
  • No pup ddsql time-series command reference remains in the requested docs or agent guides.
  • The stale positive parse test and parity-harness entry are removed.

Validation

  • cargo fmt --check — passed.
  • cargo clippy --all-targets -- -D warnings — passed.
  • cargo test -- --test-threads=1 — 1,903 passed, 0 failed on the rebased stack.
  • python3 -m py_compile scripts/test_harness.py — passed.
  • ./target/debug/pup --no-agent ddsql time-series --query 'SELECT 1' — exited 2 with the expected unknown-subcommand error.
  • ./target/debug/pup --no-agent ddsql --help — lists table, spec, and schema; no time-series reference remains.

Not run / automation gaps

  • Cross-platform compilation is left to CI.

Material deviations and decisions

Remaining work or conditions

  • CI must rerun after the rebase.
  • Keep the PR draft until explicit human approval to mark ready for review.

@nmuldavin
nmuldavin force-pushed the noah.muldavin/nbk-175-pup-remove-ddsql-time-series branch from 0740aff to eed4f21 Compare September 1, 2026 21:09
Comment thread docs/COMMANDS.md Outdated
Comment thread src/main.rs Outdated
Remove the redundant DDSQL time-series CLI path and direct users to table --limit 5000 for the former row-limit default. Reject the removed subcommand explicitly and remove it from help, docs, and the parity harness.
Remove the explicit 5,000-row replacement guidance and its dedicated parse test per review feedback.
@nmuldavin
nmuldavin force-pushed the noah.muldavin/nbk-175-pup-remove-ddsql-time-series branch from 381c689 to 19583e2 Compare September 1, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant