NBK-175: remove redundant DDSQL time-series command - #787
Draft
nmuldavin wants to merge 2 commits into
Draft
Conversation
nmuldavin
force-pushed
the
noah.muldavin/nbk-175-pup-remove-ddsql-time-series
branch
from
September 1, 2026 21:09
0740aff to
eed4f21
Compare
nmuldavin
commented
Sep 1, 2026
6 tasks
Remove the redundant DDSQL time-series CLI path and direct users to table --limit 5000 for the former row-limit default. Reject the removed subcommand explicitly and remove it from help, docs, and the parity harness.
Remove the explicit 5,000-row replacement guidance and its dedicated parse test per review feedback.
nmuldavin
force-pushed
the
noah.muldavin/nbk-175-pup-remove-ddsql-time-series
branch
from
September 1, 2026 21:57
381c689 to
19583e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
NBK-175 — https://linear.app/datadoghq/issue/NBK-175/pup-remove-ddsql-time-series
Outcome
pup ddsql time-seriesis hard-removed. Remaining examples use the generalpup ddsql tablecommand without prescribing a migration-specific row limit.Scope
Acceptance
pup ddsql time-seriesexits 2 with a clearunrecognized subcommand 'time-series'error.pup ddsql tablewithout prescribing a migration-specific row limit.pup ddsql time-seriescommand reference remains in the requested docs or agent guides.Validation
cargo fmt --check— passed.cargo clippy --all-targets -- -D warnings— passed.cargo test -- --test-threads=1— 1,903 passed, 0 failed on the rebased stack.python3 -m py_compile scripts/test_harness.py— passed../target/debug/pup --no-agent ddsql time-series --query 'SELECT 1'— exited 2 with the expected unknown-subcommand error../target/debug/pup --no-agent ddsql --help— liststable,spec, andschema; notime-seriesreference remains.Not run / automation gaps
Material deviations and decisions
pup ddsql time-seriesis removed without a compatibility alias.4ed3b64; this branch is rebased onto that merge and the PR diff now contains only NBK-175 changes.Remaining work or conditions