Repository navigation
Encode logout id in WsFed remote-failure redirect - #408
Merged
Merged
Conversation
The OnRemoteFailure handler redirected to the local logout page with the raw logoutId query value appended. URL-encode it via QueryString.Create so request input cannot alter the redirect target (CodeQL cs/web/unvalidated-url-redirection). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both changes correctly encode query data while preserving the existing logout flow, with no blocking issues identified.
No open issues 🎉
What changed in this PR
This PR hardens the WS-Federation remote-failure logout redirects in the v7 and v8 samples by encoding query data before appending it to the configured logout URL.
Changes:
- Uses
QueryString.Createto encode the logout parameter instead of concatenating its raw value. - Applies the same change to both sample versions while preserving existing failure handling.
| File | Description |
|---|---|
| IdentityServer/v8/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/WsFed/WsFedConfigureOptions.cs | Encodes the logout query parameter in the v8 redirect. |
| IdentityServer/v7/UserInteraction/WsFederationDynamicProviders/IdentityServerHost/WsFed/WsFedConfigureOptions.cs | Applies equivalent redirect encoding in v7. |
Review effort: Balanced
maartenba
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the
cs/web/unvalidated-url-redirectionalert inUserInteraction/WsFederationDynamicProviders/IdentityServerHost/WsFed/WsFedConfigureOptions.cs(v7 and v8).OnRemoteFailureredirected to the localLogoutUrland appended the rawlogoutIdquery value to it. The value is now URL-encoded withQueryString.Create, so the redirect always stays on the local logout page.Both hosts build. If CodeQL still flags the line after this merges (the target comes from configured
IdentityServerOptions), the alert will be dismissed as a false positive during triage.Part of the code scanning alert cleanup, alongside #406 and the Bootstrap, signin-redirect and log-forging PRs.