Skip to content

Encode logout id in WsFed remote-failure redirect #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maartenba merged 1 commit into from
Oct 27, 2026
Merged

Encode logout id in WsFed remote-failure redirect #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...nteraction/WsFederationDynamicProviders/IdentityServerHost/WsFed/WsFedConfigureOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ protected override void Configure(ConfigureAuthenticationContext<WsFederationOpt
ctx.Request.Path == ctx.Options.CallbackPath &&
ctx.Request.Query.ContainsKey(identityServerOptions.UserInteraction.LogoutIdParameter))
{
ctx.Response.Redirect(identityServerOptions.UserInteraction.LogoutUrl + "?" + identityServerOptions.UserInteraction.LogoutIdParameter + "=" + ctx.Request.Query[identityServerOptions.UserInteraction.LogoutIdParameter]);
// Redirect only to the local logout page; the logout id is URL-encoded so it cannot alter the target.
var logoutId = ctx.Request.Query[identityServerOptions.UserInteraction.LogoutIdParameter].ToString();
var query = QueryString.Create(identityServerOptions.UserInteraction.LogoutIdParameter, logoutId);
ctx.Response.Redirect(identityServerOptions.UserInteraction.LogoutUrl + query.ToUriComponent());
ctx.HandleResponse();
}

Expand Down
5 changes: 4 additions & 1 deletion ...nteraction/WsFederationDynamicProviders/IdentityServerHost/WsFed/WsFedConfigureOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ protected override void Configure(ConfigureAuthenticationContext<WsFederationOpt
ctx.Request.Path == ctx.Options.CallbackPath &&
ctx.Request.Query.ContainsKey(identityServerOptions.UserInteraction.LogoutIdParameter))
{
ctx.Response.Redirect(identityServerOptions.UserInteraction.LogoutUrl + "?" + identityServerOptions.UserInteraction.LogoutIdParameter + "=" + ctx.Request.Query[identityServerOptions.UserInteraction.LogoutIdParameter]);
// Redirect only to the local logout page; the logout id is URL-encoded so it cannot alter the target.
var logoutId = ctx.Request.Query[identityServerOptions.UserInteraction.LogoutIdParameter].ToString();
var query = QueryString.Create(identityServerOptions.UserInteraction.LogoutIdParameter, logoutId);
ctx.Response.Redirect(identityServerOptions.UserInteraction.LogoutUrl + query.ToUriComponent());
ctx.HandleResponse();
}

Expand Down
Loading