[chrispader]

Closing an inline editor can replace the input before delayed focus runs, and the notification banner can appear after the list measures. This PR resolves the current input when focus executes and initializes notification permission before the first layout. It also keeps list scroll notifications scoped to inverted lists and identifies local and realtime action events.

@roryabraham @dmkt9

Explanation of Change

This is layer 4 of the nine-part LegendList series. It extracts the composer and notification preparation from #100733, which remains the list migration in layer 6. Report actions continue to use the existing inverted FlashList.

Review and merge order: nine-part LegendList rollout. Layers 4 and 5 are independent preparations; merge both before layer 6.

Fixed Issues

$ #98994

Part of the migration split from #98270. No approved proposal is linked.

Tests

All platforms means desktop web, mobile web, Android, and iOS.

All platforms, save a message edit

1. Open a chat.
2. Send a short message.
3. Open that message's action menu.
4. Choose Edit.
5. Change the message text.
6. Save the edit. The updated message should appear.
7. Type in the message box at the bottom. The text should appear in that box.

All platforms, cancel a message edit

1. Open a chat containing one of your own messages.
2. Open your message's action menu.
3. Choose Edit.
4. Change the message text.
5. Cancel the edit. The original message should remain.
6. Type in the message box at the bottom. The text should appear in that box.

Android and iOS apps, keyboard after returning to a chat

1. Open a chat containing an expense preview.
2. Open the expense preview.
3. Return to the chat.
4. Tap the message box. The keyboard should open.
5. Type a message. The text should appear in the visible message box.

Desktop Chrome, notifications set to Ask

1. Set the app site's notification permission to Ask in Chrome's site settings.
2. Reload the app.
3. Open Concierge. The enable-notifications banner should be present when the chat appears, without a late jump in the messages.
4. Choose Not now. The banner should disappear.

Desktop Chrome, notifications allowed

1. Set the app site's notification permission to Allow in Chrome's site settings.
2. Reload the app.
3. Open Concierge. The enable-notifications banner should be absent.

Desktop Chrome, notifications blocked

1. Set the app site's notification permission to Block in Chrome's site settings.
2. Reload the app.
3. Open Concierge. The enable-notifications banner should be absent.

Desktop web, message hover actions while scrolling

1. Open a chat with scrollable history.
2. Hover over a message. Its action toolbar should appear.
3. Scroll the chat. The hover toolbar should disappear.

• Verify that no errors appear in the JS console

Offline tests

All platforms, cancel an edit offline

1. Open a chat containing one of your own messages while online.
2. Disconnect the internet.
3. Open your message's action menu.
4. Choose Edit.
5. Change the message text.
6. Cancel the edit. The original message should remain.
7. Type in the message box at the bottom. The text should appear in that box.
8. Reconnect the internet.

QA Steps

Run the All platforms cases and the blocks for the platform being tested, including Offline tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/FlashList/index.tsx	100.00% <100.00%> (ø)
src/components/FlatList/FlatList/index.ios.tsx	90.47% <100.00%> (ø)
src/components/FlatList/FlatList/index.tsx	50.98% <100.00%> (+50.98%)	⬆️
...c/components/KeyboardDismissibleFlatList/index.tsx	100.00% <100.00%> (+100.00%)	⬆️
src/hooks/useEmitComposerScrollEvents/index.ts	85.00% <100.00%> (+85.00%)	⬆️
...otification/notificationPermission/index.native.ts	50.00% <100.00%> (+16.66%)	⬆️
src/libs/actions/Report/index.ts	74.41% <100.00%> (-0.45%)	⬇️
src/libs/actions/Report/reportActionSubscribers.ts	100.00% <100.00%> (ø)
src/libs/focusComposerWithDelay/index.ts	100.00% <100.00%> (+3.84%)	⬆️
...rt/ReportActionCompose/ComposerWithSuggestions.tsx	67.26% <100.00%> (ø)
... and 2 more
... and 100 files with indirect coverage changes

[chrispader]

@MelvinBot request review from @roryabraham and @dmkt9 and assign them here.

[MelvinBot]

Done. I requested reviews from roryabraham and dmkt9 and added both as assignees on this PR.

---

view run