chore(deps): update analog monorepo to v2.7.5 - autoclosed - #465
ferrlabs-renovate[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Blocking: the site build breaks on this bump, and automerge is on.
Check Site fails on 14846b5, at the Build step (vite build), 2 seconds in. Install dependencies and Typecheck both pass, so this is not a lockfile-consistency problem: it dies while loading/config-resolving, before compiling anything.
Attribution looks clean rather than environmental:
- PR #466 has the identical base (
ef3c4fa), also touches onlypnpm-lock.yaml, and itsCheck Sitepasses. So the site builds fine on this base. - #463 also fails
Check Site, but off an older base (fa48f20), so it is not evidence either way here.
What actually moved is wider than the title suggests: @analogjs/vite-plugin-angular and @analogjs/vite-plugin-nitro go 2.7.2 → 2.7.5 transitively, via @analogjs/platform@2.7.4's ^2.7.4 ranges. Neither plugin changed its declared dependencies between 2.7.2 and 2.7.5 (checked against the registry), so the tinyglobby packageExtensions entry in pnpm-workspace.yaml still applies and is not the cause. The plausible culprit is 2.7.3's vite-plugin-angular: preprocess styles with the top-level resolved config (#2557), which changes how the plugin reads the resolved Vite config, exactly the phase that is failing.
I could not read the job log to confirm the error text (the logs endpoint returns 403, admin rights required), so the specific upstream commit is inference, not verified. The failure itself and its attribution to this PR are verified.
Recommendation: reproduce pnpm --filter @lfsx/site build locally to get the actual error. If it is the #2557 change, pin the plugin through the existing pnpm-workspace.yaml overrides block ('@analogjs/vite-plugin-angular': 2.7.2) and file upstream, rather than pinning the whole monorepo back, since the 2.7.4 fix you do want is the unrelated Vitest 5 peer range. Do not let this automerge red.
14846b5 to
174ade4
Compare
174ade4 to
1a09d7d
Compare
There was a problem hiding this comment.
Head moved to 2.7.5 on a new base (9689559) and Check Site still fails, so 2.7.5's lazily create JavaScript transformers fix is not the missing piece.
My earlier guess at the cause was wrong, and the fix I suggested (pinning @analogjs/vite-plugin-angular to 2.7.2) would not help. Evidence: #403 carries 2.7.5 for all five @analogjs packages off the identical base and its Check Site is green. I extracted the @analogjs blocks from both lockfiles: within that subtree the single difference is the optional peer of vite-plugin-angular, @angular/build 22.1.8 here versus 22.2.0 in #403.
On base 9689559:
| analog | @angular/build | Check Site |
|---|---|---|
| 2.7.2 | 22.1.8 | green (main, #467) |
| 2.7.5 | 22.1.8 | red (this PR) |
| 2.7.2 | 22.2.0 | red (#463) |
| 2.7.5 | 22.2.0 | green (#403) |
Each bump alone is red, the pair together is green, so the two have to move in one branch. Caveat: #403 also refreshes rolldown, sass-embedded and @emnapi/*, so it is not a clean two-factor isolation, and #463's red is assumed to be this same failure rather than verified as such.
Recommendation: add a renovate.json packageRule grouping @analogjs/* with @angular/build under one groupName, the same shape as the existing OpenTelemetry rule and for the same reason, so whatever is released together is judged together by CI. Short term, the working combination already exists in #403: landing that and letting Renovate rebuild this branch and #463 gets you there without a pin to unwind later.
Still no access to the job log (the logs endpoint returns 403, admin rights required), so the actual build error text remains unverified. Everything above comes from the lockfiles and check-run conclusions.
Pull request was closed
This PR contains the following updates:
2.7.2→2.7.52.7.2→2.7.52.7.2→2.7.5Release Notes
analogjs/analog (@analogjs/content)
v2.7.5Compare Source
Bug Fixes
v2.7.4Compare Source
Bug Fixes
v2.7.3Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.