Skip to content

fix(server): announce the bucket settings once at boot - #511

Merged
BryanFRD merged 1 commit into
mainfrom
fix/review-nits-boot
Oct 3, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
fix/review-nits-boot

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Closes #510

@BryanFRD
BryanFRD enabled auto-merge (squash) October 3, 2026 07:46

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. The warnings and their conditions moved unchanged, cache.is_some() matches the old disk.is_some() since disk comes from cache, and the allowed rewrite behaves the same.

Nit: boot_log.rs still only tests the access warning on a volume config. A bucket config asserting that "objects and locks are stored in a bucket" shows up once would cover #510 directly.

@BryanFRD
BryanFRD merged commit 27e1d9f into main Oct 3, 2026
27 checks passed
@BryanFRD
BryanFRD deleted the fix/review-nits-boot branch October 3, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bucket-mode boot warnings still print once per backend construction

1 participant