fix(server): announce the bucket settings once at boot - #511
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 3, 2026 07:46
Contributor
There was a problem hiding this comment.
Looks correct. The warnings and their conditions moved unchanged, cache.is_some() matches the old disk.is_some() since disk comes from cache, and the allowed rewrite behaves the same.
Nit: boot_log.rs still only tests the access warning on a volume config. A bucket config asserting that "objects and locks are stored in a bucket" shows up once would cover #510 directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
backendsintoannounce_storage, called fromappnext toannounce_access, so a bucket deployment prints them once instead of once per backend construction.boot_log.rsdrops the retry loop: one test on a current-thread runtime, so a broken capture now fails on the first pass (review of fix(server): announce the access settings once at boot #505).allowedreadsis_set(value).then(...)instead of rewrapping the option (review of fix(config): warn about ignored access variables from their raw value #507).separateMajorMinor: false, so a minor of one that needs a major of the other still lands in one branch (review of chore(renovate): update Analog and the Angular build tooling together #509).