Repository navigation
Fix department and time bonus policy crashes - #77
Open
travismolick wants to merge 2 commits into
Open
travismolick wants to merge 2 commits into
travismolick wants to merge 2 commits into
Conversation
travismolick
added
bug
travismolick
marked this pull request as ready for review
October 18, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DepartmentPolicywas missing theApp\Models\Eventimport.viewForEvent()threw a TypeError, so managers and volunteers got a 500 on the department list. Admins weren't affected because theGate::beforehook lets them skip policies.TimeBonusdidn't use theChecksActiveEventtrait.TimeBonusPolicy::view()calledisForActiveEvent(), which didn't exist, so non-managers got a 500 when viewing a single time bonus.The new tests in #78 found both bugs.
DepartmentTestandTimeBonusTestcover them.