Skip to content

chore(gae): Remove unused gae_java8_datastore_inequality_filters_sort_orders_invalid_2 and ...invalid_1 region tag - #10315

Open
Kef131 wants to merge 1 commit into
mainfrom
refactor(gae)-remove_unused_region_tags
Open

chore(gae): Remove unused gae_java8_datastore_inequality_filters_sort_orders_invalid_2 and ...invalid_1 region tag#10315
Kef131 wants to merge 1 commit into
mainfrom
refactor(gae)-remove_unused_region_tags

Conversation

@Kef131

@Kef131 Kef131 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/347352192

Removed unused region tags gae_java8_datastore_inequality_filters_sort_orders_invalid_2 and gae_java8_datastore_inequality_filters_sort_orders_invalid_1

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jul 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused documentation region tags (gae_java8_datastore_inequality_filters_sort_orders_invalid_1 and gae_java8_datastore_inequality_filters_sort_orders_invalid_2) from the QueriesTest.java file in the App Engine Datastore tests. There are no review comments, and I have no feedback to provide on these changes.

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any references with these region tags. LGTM!

@Kef131
Kef131 marked this pull request as ready for review July 27, 2026 15:32
@Kef131
Kef131 requested review from a team and yoshi-approver as code owners July 27, 2026 15:32
@snippet-bot

snippet-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants