Skip to content

chore(gae): Remove unused gae_java8_datastore_inequality_filters_sort_orders_invalid_2 and ...invalid_1 region tag #10315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kef131 merged 1 commit into from
Jul 28, 2026
+0 −4
Merged

chore(gae): Remove unused gae_java8_datastore_inequality_filters_sort_orders_invalid_2 and ...invalid_1 region tag #10315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions appengine-java8/datastore/src/test/java/com/example/appengine/QueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ public void queryRestrictions_inequalitySortedFirst_returnsMatchedEntities() thr
@Test
public void queryRestrictions_missingSortOnInequality_isInvalid() throws Exception {
long minBirthYear = 1940;
// [START gae_java8_datastore_inequality_filters_sort_orders_invalid_1]
Filter birthYearMinFilter =
new FilterPredicate("birthYear", FilterOperator.GREATER_THAN_OR_EQUAL, minBirthYear);

Expand All @@ -614,7 +613,6 @@ public void queryRestrictions_missingSortOnInequality_isInvalid() throws Excepti
new Query("Person")
.setFilter(birthYearMinFilter)
.addSort("lastName", SortDirection.ASCENDING);
// [END gae_java8_datastore_inequality_filters_sort_orders_invalid_1]

// Note: The local devserver behavior is different than the production
// version of Cloud Datastore, so there aren't any assertions we can make
Expand All @@ -625,7 +623,6 @@ public void queryRestrictions_missingSortOnInequality_isInvalid() throws Excepti
@Test
public void queryRestrictions_sortWrongOrderOnInequality_isInvalid() throws Exception {
long minBirthYear = 1940;
// [START gae_java8_datastore_inequality_filters_sort_orders_invalid_2]
Filter birthYearMinFilter =
new FilterPredicate("birthYear", FilterOperator.GREATER_THAN_OR_EQUAL, minBirthYear);

Expand All @@ -635,7 +632,6 @@ public void queryRestrictions_sortWrongOrderOnInequality_isInvalid() throws Exce
.setFilter(birthYearMinFilter)
.addSort("lastName", SortDirection.ASCENDING)
.addSort("birthYear", SortDirection.ASCENDING);
// [END gae_java8_datastore_inequality_filters_sort_orders_invalid_2]

// Note: The local devserver behavior is different than the production
// version of Cloud Datastore, so there aren't any assertions we can make
Expand Down