[dfcoffin]

Summary

Follow-up to #244: finishes the Green Button Alliance theme pass on the Data Custodian and adds tests that lock the theme in. The two legacy customer pages are deliberately untouched; their implementation is tracked in #245.

Restyle (decorative colours only)

• Admin dashboard: the five action buttons and icons are GBA green; they were green/cyan/red/yellow, and Notify isn't destructive, so it isn't red. The four coloured statistic cards are now white gba-stat tiles with a green rule and figure.
• Login: feature icons in GBA green.
• Error pages: "Try Again" is btn-outline-primary; the 5 rem icon size moved from inline style= to a theme class.
• Kept on purpose (semantic):
  • status badges (Active/Revoked/Expired/Pending, Enabled, role);
  • the red Delete and Revoke buttons;
  • the warning/danger error icons;
  • the neutral Cancel and Go Back buttons.

Footer and layout

• In 18 templates the footer moves out of the page .container and becomes a full-width child of <body>. The leftover <hr> separators are removed, and the content area grows so the footer sits at the bottom of short pages (checked on the Change Password page).
• The full-bleed CSS workaround stays only for the two legacy pages, with a comment pointing at DC customer portal: implement usage points, Download My Data and the legacy customer home (or retire them) #245.

CSS cleanup

• DC application.css is cut to the rules still in use that the theme doesn't cover: table header row, focus outline, print. The old Material palette, radii, hover lifts, gradients and light footer were fighting the theme.
• The theme drops most of its !important overrides and the --gb-* bridge. The remaining !importants are on the hero, where Bootstrap's own !important utilities still appear in markup.
• The theme now keeps inputs and tables white. Bootstrap fills them with the body colour, which the theme sets to the grey page background.

Small fix

In the retail customers list, Delete is now btn-sm like View and Edit. btn-group-sm doesn't reach a button nested in a <form>.

Tests

• GbaThemeResourcesTest (DC):
  • the theme, logo, GBA favicon and the old DC favicon are served anonymously with the right content type;
  • the logo starts with the PNG signature, which guards against the resource-filtering corruption the feat(ui): shared Green Button Alliance theme and Third Party layout (prototype) #244 pom fix avoids;
  • the home page renders the GBA layout with SRI-pinned assets.
• GbaLayoutPagesTest (TP; the first Third Party test that boots a full Spring context):
  • /, /login, /TermsOfService and /UsagePolicy render anonymously with the GBA layout, SRI assets and no root-relative /about link;
  • the theme assets are served.

Test plan

• mvn verify DC: 178 tests pass (+6); TP: 51 pass (+7, 2 skipped, pre-existing)
• Live on the local profile, logged in as the dev admin: dashboard, Change Password (footer pinned to the bottom, full width, parentElement = BODY) and Retail Customers (white table, green header row)

🤖 Generated with Claude Code