Repository navigation
fix(grid): preselect custom conditions in Excel-style filtering - #17786
Open
viktorkombov wants to merge 6 commits into
Open
viktorkombov wants to merge 6 commits into
viktorkombov wants to merge 6 commits into
Conversation
viktorkombov
added
🐛 bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized fix preserves fallback behavior, includes targeted regression coverage, and has no identified blocking issues.
0 open findings
What changed in this PR
Fixes #17636 by preselecting custom conditions when opening the grids’ Excel-style filter dialog before entering a value.
Changes:
- Resolves conditions from column filters first, preserving the built-in fallback.
- Adds string, number, and fallback regression tests.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts | Adds three regression tests. |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-custom-dialog.component.ts | Prioritizes custom condition lookup. |
| CHANGELOG.md | Records the fix for all three grid types. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 16, 2026
# Conflicts: # projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts
teodosiah
added
💥 status: in-test
kdinev
requested changes
Oct 23, 2026
| - Touch pans no longer leave slides partially moved or visible behind the current slide, for example when a pan is cancelled, reversed past the first or last slide of a non-looping carousel, released as a tap, or interrupted by removing slides or changing `gesturesSupport` or `vertical`. | ||
| - Panning a carousel without slides no longer throws an error, and panning a carousel with a single slide no longer moves the slide against itself. | ||
| - A slide activated through its `active` property now animates in the direction of its position, or in its own `direction` when one is set. | ||
| - `IgxGridComponent`, `IgxTreeGridComponent`, `IgxHierarchicalGridComponent` |
Member
There was a problem hiding this comment.
@viktorkombov The changelog entry should be the same as in 22.2.x - the bug fix applies to 22.2.4, like you've noted in the changelog there. Same entry should exist here.
The fix is backported to 22.2.x in #17788, where it is listed under 22.2.4, so list it in the same section on master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17636
Description
Preselect custom conditions in the Excel-style filter dialog while preserving the built-in fallback.
Motivation / Context
Custom operands were blank when opening the dialog before entering a filter value.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grid, Tree Grid and Hierarchical Grid — Excel-style filtering.
How Has This Been Tested?
147 ESF tests passed, including three regressions. Strict TypeScript/Angular compilation and
npm run lint:libpassed.Test Configuration:
Screenshots / Recordings
N/A
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)