Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The demo’s new primary key permits duplicate IDs that can cause deletion of the wrong record.
3 open issues
What changed in this PR
Fixes #17693 by applying column formatting to populated, uncommitted add-row cells while preserving empty-cell placeholders.
Changes:
- Updates shared, tree-grid, and master-detail cell templates.
- Adds formatting regression tests across grid variants.
- Updates the demo’s primary key and release notes.
| File | Description |
|---|---|
| src/app/grid-add-row/grid-add-row.sample.html | Sets the demo primary key to ID. |
| projects/igniteui-angular/grids/tree-grid/src/tree-grid-add-row-ui.spec.ts | Adds a date-formatting regression test. |
| projects/igniteui-angular/grids/tree-grid/src/tree-cell.component.html | Formats populated tree add-row cells. |
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid-add-row.spec.ts | Adds hierarchical-grid date coverage. |
| projects/igniteui-angular/grids/grid/src/grid-add-row.spec.ts | Tests date and numeric formatting. |
| projects/igniteui-angular/grids/grid/src/expandable-cell.component.html | Applies formatting and preserves zero values. |
| projects/igniteui-angular/grids/core/src/cell.component.html | Applies formatting in shared add-row cells. |
| CHANGELOG.md | Documents the fix; repeats a Forms entry. |
Review effort: Balanced
…into thristodorova/fix-17693
…/igniteui-angular into thristodorova/fix-17693
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Two small things in CHANGELOG.md:
|
1 of 23 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #17693
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)