Skip to content

fix(grids): preserve column formatting in newly added rows - #17810

Open
teodosiah wants to merge 8 commits into
masterfrom
thristodorova/fix-17693
Open

teodosiah wants to merge 8 commits into
masterfrom
thristodorova/fix-17693

Conversation

@teodosiah

Copy link
Copy Markdown
Contributor

Closes #17693

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The demo’s new primary key permits duplicate IDs that can cause deletion of the wrong record.

3 open issues
What changed in this PR

Fixes #17693 by applying column formatting to populated, uncommitted add-row cells while preserving empty-cell placeholders.

Changes:

  • Updates shared, tree-grid, and master-detail cell templates.
  • Adds formatting regression tests across grid variants.
  • Updates the demo’s primary key and release notes.
File Description
src/​app/​grid-add-row/​grid-add-row.sample.html Sets the demo primary key to ID.
projects/​igniteui-angular/​grids/​tree-grid/​src/​tree-grid-add-row-ui.spec.ts Adds a date-formatting regression test.
projects/​igniteui-angular/​grids/​tree-grid/​src/​tree-cell.component.html Formats populated tree add-row cells.
projects/​igniteui-angular/​grids/​hierarchical-grid/​src/​hierarchical-grid-add-row.spec.ts Adds hierarchical-grid date coverage.
projects/​igniteui-angular/​grids/​grid/​src/​grid-add-row.spec.ts Tests date and numeric formatting.
projects/​igniteui-angular/​grids/​grid/​src/​expandable-cell.component.html Applies formatting and preserves zero values.
projects/​igniteui-angular/​grids/​core/​src/​cell.component.html Applies formatting in shared add-row cells.
CHANGELOG.md Documents the fix; repeats a Forms entry.

Review effort: Balanced

Comment thread src/app/grid-add-row/grid-add-row.sample.html

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Repeated demo additions create duplicate primary keys, allowing deletion to remove the wrong row.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread src/app/grid-add-row/grid-add-row.sample.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues remain; the changes follow existing formatting logic and include focused regression tests, though tests were not executed.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@viktorkombov viktorkombov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 23, 2026
@viktorkombov

viktorkombov commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Two small things in CHANGELOG.md:

  • The Forms entry (igx-checkbox, igx-switch and igx-radio-group with Signal Forms) is already listed under ## 22.2.2, so it now appears twice. Looks like a merge leftover, could you remove it from ## Unreleased?
  • Since this fix is also backported to 22.2.x (fix(grids): preserve column formatting in newly added rows - 22.2.x #17833), should the grid entry go under the next 22.2.x patch section instead of ## Unreleased?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: row-adding ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

igx-grid: add row cells ignore pipeArgs/formatter and display the raw value (e.g. dates)

3 participants