Repository navigation
Conversation
teodosiah
changed the title
teodosiah
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Repeated demo additions create duplicate primary keys, causing deletion to target the wrong record.
1 open issue
What changed in this PR
Fixes #17693 by applying column formatting to non-editing cells in uncommitted add rows.
Changes:
- Applies formatters and pipe arguments across standard, expandable, and tree-grid cells.
- Adds formatting regression tests across grid variants.
- Updates the add-row demo’s primary key and sample record.
| File | Description |
|---|---|
| src/app/grid-add-row/grid-add-row.sample.ts | Updates the inserted demo record. |
| src/app/grid-add-row/grid-add-row.sample.html | Configures the ID primary key. |
| projects/igniteui-angular/grids/tree-grid/src/tree-grid-add-row-ui.spec.ts | Tests add-row date formatting. |
| projects/igniteui-angular/grids/tree-grid/src/tree-cell.component.html | Formats tree-grid add-row values. |
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid-add-row.spec.ts | Tests hierarchical-grid date formatting. |
| projects/igniteui-angular/grids/grid/src/grid-add-row.spec.ts | Tests typed formatting and expandable cells. |
| projects/igniteui-angular/grids/grid/src/expandable-cell.component.html | Formats values and preserves zero. |
| projects/igniteui-angular/grids/core/src/cell.component.html | Formats standard add-row values. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
teodosiah
added
❌ status: awaiting-test
viktorkombov
added
✅ status: verified
1 of 23 tasks
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17693
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)