Repository navigation
fix(pivot-grid): span collapsed and summary row headers across columns - #17847
Open
viktorkombov wants to merge 2 commits into
Open
viktorkombov wants to merge 2 commits into
viktorkombov wants to merge 2 commits into
Conversation
In the horizontal row layout, size collapsed and summary row headers to the combined width of the columns they span instead of the first one, and do not measure auto-sized dimensions again from them. Closes #17222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7 of 23 tasks
7 of 23 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused sizing changes have targeted regression coverage and no unresolved findings; tests were not executed in this review environment.
No open issues 🎉
What changed in this PR
Fixes the Pivot Grid horizontal row-header regression reported in #17222 and introduced by #16201, restoring full-width collapsed and summary headers.
Changes:
- Uses the parent’s merged width for horizontal row headers.
- Preserves existing auto-sized dimension widths during subsequent sizing passes.
- Adds regression tests for spanning headers and stable auto-sizing, plus a changelog entry.
| File | Description |
|---|---|
projects/igniteui-angular/grids/pivot-grid/src/pivot-row-dimension-header-group.component.ts |
Sizes horizontal headers using the merged parent width. |
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts |
Tests summary and collapsed header widths and auto-sizing stability. |
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts |
Skips dimensions that already have an auto width. |
CHANGELOG.md |
Documents the fix under version 22.2.4. |
Review effort: Balanced
Collapsed and summary row headers span several dimensions, but resizing changes only the first one, so measure that dimension for the resize line limits instead of the merged header. Closes #17222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17222
Description
In the horizontal row layout, collapsed row headers and summary (
Total) headers now fill all the columns they span. Before, they were only as wide as their first column.Motivation / Context
Regression from #16201 (20.1.0):
getHeaderWidthFromDimension()moved to the header group and returned its own column width (this.width) instead of the merged cell width (this.parent.width).autoSizeDimensionsInView()now skips dimensions that already have an auto width, so these wider headers do not widen them when it runs again. Resizing such a header changes only its first dimension, so the resize line limits are measured from that dimension.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Pivot Grid
How Has This Been Tested?
New horizontal layout specs in
pivot-grid.spec.ts: the summary and collapsed headers are as wide as the columns they span (fails without the fix), an auto-sized dimension keeps its width when another auto-sized dimension is enabled, and the resize line of a summary header stops at the minimum width of its first dimension. The pivot grid specs pass, and the Pivot State demo was checked before and after the fix.Test Configuration:
Screenshots / Recordings
The issue shows the actual and the expected result.
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)🤖 Generated with Claude Code