Repository navigation
fix(webapp): let the player's cover take its clicks, and give the bar room - #294
Merged
Merged
Conversation
… room - The names beside the player's cover shared its grid cell and were set beside it by a padding, so their box lay over the cover and took every click aimed at its middle; only the strip above the names reached the album link. They are set beside it by a margin now. - The bar grows from 4.25 to 5.25 rem, the cover from 3.25 to 3.75 rem and the play button with them; the rail ends above the taller bar. - Queue and saved-position rows get room inside them, so the cover no longer sits against the open row's accent edge, and the row's own button no longer turns into a ghost pill when hovered. Signed-off-by: InstaZDLL <github.105mh@8shield.net>
github-actions
Bot
added
type: fix
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
Le titre décrit clairement les deux changements principaux : la zone cliquable de la couverture et l’augmentation de l’espace de la barre du lecteur. |
| Description check | |
La description contient un résumé, une liste des changements, un plan de test détaillé et la confirmation DCO. La section Notes est omise, ce qui est autorisé lorsqu’elle n’est pas nécessaire. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 Biome (2.5.14)
-
webapp/src/styles/fluid.css
-
Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.
-
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three follow-ups to the Fluid Editorial pass (#289), reported from use.
Changes
.player-trackshares the cover's grid cell and was pushed beside it withpadding-left, so its box lay over the cover and swallowed clicks on its middle. It is now pushed withmargin-left, so the box starts after the cover. Measured withelementFromPointat 15 %, 50 % and 85 % of the cover's height: before, only the first reached the link; now all three do.Dark themes only, like the rest of
fluid.css.Test plan
bun run lint(the 7 warnings left are inrefresh.css, unchanged)bun run buildbun run test— 179 passedbun run dev: the player bar's height and cover hit test, the queue with the playing rowBy submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0-only license and is signed off via the Developer Certificate of Origin (
git commit -s).Summary by CodeRabbit