feat(cloud-agent): scoped runtime credentials (2/3) - #5975
Open
pandemicsyn wants to merge 11 commits into
Open
Conversation
This was referenced Sep 8, 2026
pandemicsyn
marked this pull request as ready for review
September 8, 2026 17:24
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental commits restore runtime-authorization seals on create retries, attest model-validation and control-plane ingest, and add recovery diagnostics; previous findings are resolved and no new high-confidence issues were found. Files Reviewed (19 files)
Previous Review Summary (commit c2f50a5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c2f50a5)Status: 2 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)CRITICAL
WARNING
Files Reviewed (111 files)
Reviewed by grok-4.6 · Input: 301.1K · Output: 27.4K · Cached: 1.6M Review guidance: REVIEW.md from base branch |
intentionally-left-nil
left a comment
intentionally-left-nil
left a comment
Contributor
There was a problem hiding this comment.
too much code to review, here's a first pass :)
eshurakov
reviewed
Sep 9, 2026
eshurakov
reviewed
Sep 9, 2026
eshurakov
approved these changes
Sep 9, 2026
Preserve runtime isolation documentation and use scoped control tokens for the newly added worktree file routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add Cloud Agent scoped runtime credentials, isolation, renewal/recovery, and web producer wiring. Lost-response create retries retain runtime authorization. Recovery failures emit credential-free diagnostics, including throttled warnings for prolonged locks, while preserving retirement fences.
Stack: foundation #5974 → Cloud Agent #5975 → remaining families #5976. Original #5857 remains unchanged.
Rollout
Resolve the outstanding Cloud Agent smoke failures before merging. Then wait for the foundation deployment to be healthy before merging this PR.
RUNTIME_ISOLATION_ENABLEDSHARED_RESOURCE_TOKENS_ENABLEDCLOUD_AGENT_RESOURCE_TOKENS_ENABLEDIsolation permits modern workspace admission; it does not issue modern tokens or migrate legacy sessions. Cloud Agent activation does not need to wait for #5976. Rollback stops new issuance while retaining readers and runtime support for existing credentials.
Validation