feat(auth): remaining token families (3/3) - #5976
Open
pandemicsyn wants to merge 9 commits into
Open
Conversation
This was referenced Sep 8, 2026
pandemicsyn
marked this pull request as ready for review
September 8, 2026 17:24
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Previous Review Summary (commit 287ed27)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 287ed27)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (109 files)
Reviewed by grok-4.6 · Input: 95.8K · Output: 20.6K · Cached: 831.6K Review guidance: REVIEW.md from base branch |
intentionally-left-nil
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add the remaining token families: native/mobile, Chat, explicit delegation, benchmark, Gastown/Wasteland, and automation Workers. Update rollout documentation for the stack.
Stack: foundation #5974 → Cloud Agent #5975 → remaining families #5976.
Defaults
No additional issuance flag ships on. Cloud Agent isolation is already enabled by #5975. The shared web master may already be on; these independent family gates remain off.
CHAT_RESOURCE_TOKENS_ENABLEDDELEGATED_RESOURCE_TOKENS_ENABLEDWORKFLOW_GATEWAY_RESOURCE_TOKENS_ENABLEDBENCHMARK_RESOURCE_TOKENS_ENABLEDNATIVE_RESOURCE_TOKENS_ENABLEDGASTOWN_RESOURCE_TOKENS_ENABLEDWASTELAND_RESOURCE_TOKENS_ENABLEDSHARED_RESOURCE_TOKENS_ENABLEDin Security Auto Analysis and Webhook Agent IngestAfter verification, enable one family at a time. Web families also require web
SHARED_RESOURCE_TOKENS_ENABLED=true; Worker-local settings are independent. Rollback retains support for already-issued credentials.Validation and preservation
632 focused tests, eight Gastown storage integration tests, affected typechecks, lint, and diff checks passed during extraction. This follow-up changes rollout documentation only within this PR's diff; Markdown checks pass.
The complete implementation from
ad3dbc51ais retained. The stack includes the isolation configuration/generated types, rollout documentation, and reviewed Cloud Agent registration/recovery fixes. Physical-device, real-provider, and complete Cloud Agent smoke coverage remain incomplete.