Skip to content

feat(mobile): bring GitLab and Bitbucket pull request review to GitHub parity (stack 16/30) - #6013

Closed
iscekic wants to merge 2 commits into
kwf/bring-mobile-gitlab-and-bitb-3792-l15from
kwf/bring-mobile-gitlab-and-bitb-3792-l16
Closed

feat(mobile): bring GitLab and Bitbucket pull request review to GitHub parity (stack 16/30)#6013
iscekic wants to merge 2 commits into
kwf/bring-mobile-gitlab-and-bitb-3792-l15from
kwf/bring-mobile-gitlab-and-bitb-3792-l16

Conversation

@iscekic

@iscekic iscekic commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Not verified. kwf reopened this section on 2026-09-09: publication failed: level 2: pr-api: HTTP/2.0 422 Unprocessable Entity
pr-api: date: Wed, 09 Sep 2026 17:39:45 GMT
pr-api: x-ratelimit-limit: 5000
pr-api: x-ratelimit-remaining: 4901
pr-api: x-ratelimit-used: 99
pr-api: x-ratelimit-reset: 1788978098
pr-api: x-ratelimit-resource: core
pr-api: x-githu
The proof below came from an earlier round and can be stale. Do not review until this note is gone.

Level 16 of the bring-mobile-gitlab-and-bitb-3792 stack.

  • fix: fix the failed device scenarios (kwf bring-mobile-gitlab-and-bitb-3792/vr1)
  • chore: bring-mobile-gitlab-and-bitb-3792 pre-verify snapshot

PR stack (merge bottom to top)

This was referenced Sep 9, 2026
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Draft
@iscekic
iscekic marked this pull request as draft September 9, 2026 17:31
kilo-code-bot[bot]
kilo-code-bot Bot reviewed Sep 9, 2026
View reviewed changes
Comment thread apps/web/src/lib/provider-review/bitbucket-read.ts
return { items, nextCursor: page.nextCursor };
items.sort((left, right) => inboxUpdatedMs(right) - inboxUpdatedMs(left));
const trimmed = items.slice(0, BITBUCKET_PAGE_SIZE);
if (items.length > trimmed.length) hasMore = true;

@kilo-code-bot kilo-code-bot Bot Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Inbox pagination drops PRs when the merged page exceeds 50

listInbox requests the same Bitbucket page from every repository, merges and sorts the results, then slices to 50 and advances page+1. Leftovers from that merged window are never fetched: two repos with 30 open PRs each return 50 items on page 1 and an empty page 2, silently dropping 10 PRs. hasMore from items.length > trimmed.length paginates the per-repo Bitbucket axis, not the trimmed merged list.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Bitbucket inbox pagination slices a merged repo fan-out to 50 then advances the per-repo Bitbucket page, so leftover PRs are silently dropped.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/lib/provider-review/bitbucket-read.ts 899 Inbox pagination drops PRs when the merged page exceeds 50
Files Reviewed (22 files)
  • apps/web/src/lib/provider-review/bitbucket-read.ts - 1 issue
  • apps/web/src/lib/provider-review/bitbucket-read.test.ts
  • apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx
  • apps/mobile/src/components/agents/new-session-configure-form.tsx
  • apps/mobile/src/components/agents/picker-search.mounted.test.tsx
  • apps/mobile/src/components/agents/repository-branch-selector.tsx
  • apps/mobile/src/components/agents/session-detail-content.tsx
  • apps/mobile/src/components/picker-sheet.tsx
  • apps/mobile/src/components/pr-review/full-surface-states.mounted.test.tsx
  • apps/mobile/src/components/pr-review/pr-form-sheet-chrome.tsx
  • apps/mobile/src/components/pr-review/pr-review-comment-composer-screen.tsx
  • apps/mobile/src/components/pr-review/pr-review-connect-gate.tsx
  • apps/mobile/src/components/pr-review/pr-review-provider-sheet-href.ts
  • apps/mobile/src/components/pr-review/pr-review-screen.tsx
  • apps/mobile/src/components/pr-review/pr-review-submit.tsx
  • apps/mobile/src/components/pr-review/pr-review-tab-selector.tsx
  • apps/mobile/src/glanceable-android/active-agents-widget.tsx
  • apps/mobile/src/i18n/locales/en.json
  • apps/mobile/src/lib/pr-review/use-provider-inbox.ts
  • apps/mobile/src/lib/pr-review/use-provider-inbox.test.ts
  • patches/expo-router@57.0.15.patch
  • pnpm-lock.yaml

Fix these issues in Kilo Cloud

Reviewed by grok-4.6 · Input: 313.1K · Output: 19.9K · Cached: 424.1K

Review guidance: REVIEW.md from base branch kwf/bring-mobile-gitlab-and-bitb-3792-l15

@iscekic iscekic closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilo-code-bot kilo-code-bot[bot] kilo-code-bot[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iscekic