Skip to content

feat(mobile): bring GitLab and Bitbucket pull request review to GitHub parity (stack 24/30) - #6016

Closed
iscekic wants to merge 1 commit into
kwf/bring-mobile-gitlab-and-bitb-3792-l23from
kwf/bring-mobile-gitlab-and-bitb-3792-l24
Closed

feat(mobile): bring GitLab and Bitbucket pull request review to GitHub parity (stack 24/30)#6016
iscekic wants to merge 1 commit into
kwf/bring-mobile-gitlab-and-bitb-3792-l23from
kwf/bring-mobile-gitlab-and-bitb-3792-l24

Conversation

@iscekic

@iscekic iscekic commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Not verified. kwf reopened this section on 2026-09-09: publication failed: level 2: pr-api: HTTP/2.0 422 Unprocessable Entity
pr-api: date: Wed, 09 Sep 2026 17:39:45 GMT
pr-api: x-ratelimit-limit: 5000
pr-api: x-ratelimit-remaining: 4901
pr-api: x-ratelimit-used: 99
pr-api: x-ratelimit-reset: 1788978098
pr-api: x-ratelimit-resource: core
pr-api: x-githu
The proof below came from an earlier round and can be stale. Do not review until this note is gone.

Level 24 of the bring-mobile-gitlab-and-bitb-3792 stack.

  • fix: fix visual defects from the spot check (kwf bring-mobile-gitlab-and-bitb-3792/uxs2)

PR stack (merge bottom to top)

This was referenced Sep 9, 2026
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Draft
@iscekic
iscekic marked this pull request as draft September 9, 2026 17:31
kilo-code-bot[bot]
kilo-code-bot Bot reviewed Sep 9, 2026
View reviewed changes
Comment thread apps/mobile/src/lib/pr-review/provider-pr-queries.ts
// absent at once (spot check e7). Drop them here, where the provider
// shape is read, so the tab's empty check sees the truth.
threads: page.threads
.filter(thread => thread.comments.length > 0)

@kilo-code-bot kilo-code-bot Bot Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Empty GitLab discussion pages still keep nextCursor, so later human comments can become unreachable

Filtering comments.length === 0 can yield threads: [] while nextCursor still reflects the raw GitLab page of 50 discussions. selectDiscussionTabView then treats that as terminal empty and never mounts the list/fetchNextPage. A first page of system-only notes (pushes, labels, assignments) will hide real comments on later pages.

Keep fetching while nextCursor is set, or compact empty pages before the empty check.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/mobile/src/lib/pr-review/provider-pr-queries.ts 182 Filtering empty GitLab threads can hide later-page comments because nextCursor is kept while the tab treats the page as terminal empty
Files Reviewed (10 files)
  • apps/mobile/src/components/agents/repository-branch-selector.mounted.test.tsx - 0 issues
  • apps/mobile/src/components/pr-review/diff/pr-diff-floating-actions.backdrop.test.tsx - 0 issues
  • apps/mobile/src/components/pr-review/diff/pr-diff-floating-actions.test.tsx - 0 issues
  • apps/mobile/src/components/pr-review/diff/pr-diff-floating-actions.tsx - 0 issues
  • apps/mobile/src/components/pr-review/pr-review-discussion-tab-view.test.ts - 0 issues
  • apps/mobile/src/components/pr-review/pr-review-discussion-tab-view.ts - 0 issues
  • apps/mobile/src/components/pr-review/pr-review-discussion-tab.test.tsx - 0 issues
  • apps/mobile/src/components/pr-review/pr-review-discussion-tab.tsx - 0 issues
  • apps/mobile/src/lib/pr-review/provider-pr-queries.test.ts - 0 issues
  • apps/mobile/src/lib/pr-review/provider-pr-queries.ts - 1 issue

Fix these issues in Kilo Cloud

Reviewed by grok-4.6 · Input: 175.1K · Output: 13.4K · Cached: 321.2K

Review guidance: REVIEW.md from base branch kwf/bring-mobile-gitlab-and-bitb-3792-l23

@iscekic iscekic closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilo-code-bot kilo-code-bot[bot] kilo-code-bot[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iscekic