gmoccapy: don't show_all() containers holding embedded tabs - #4357
Merged
Conversation
show_all() on ntb_preview recursively unhid widgets hidden at init, i.e. the lathe-only back-tool view button rbt_view_y2, making it appear on mill configs. Show only the container, the socket and its tab label. Fixes LinuxCNC#4353
Contributor
|
Thak you for fix. It works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4353
_init_dynamic_tabs() called show_all() on the container receiving an
embedded tab. show_all() is recursive, so with
EMBED_TAB_LOCATION = ntb_preview it undid the hides gmoccapy applied at
startup, e.g. the lathe-only back-tool view button rbt_view_y2, which
then showed up as a bogus second "Y" view button on mill configs.
Show only the container itself plus the added socket and its tab label
instead.
Tested with gmoccapy_with_user_tabs.ini and works for me: single "Y"
button on the preview row, both embedded tabs still populate. Back-tool
lathe configs keep their two Y views.
@zz912 could you test this with your config?