Repository navigation
feat(landing): Windows server monitoring tools guide - #1581
JeremyFunk wants to merge 11 commits into
Confidence 6/10 · 1 issue to address
🟡 Confidence 6/10 · needs attention. Held at 6 because a correctness warning is open.
1 warning −1 · 1 note · tests partial −1 · risk low
Adds a Windows Server monitoring guide page with a Collector config, two PowerShell scripts, a powershell highlighter, and index/llms.txt entries. The copy and config check out against the repo's docs; the install script still points at a non-existent MSI.
Findings
🔵 Note · F4 · Takeaways say the built-in tools send no alerts, contradicting the table
correctness · apps/landing/src/pages/guides/windows-server-monitoring.astro:322
The box says the built-in tools "send no alerts", but the Alerts column of the tools table (windows-server-monitoring.astro:108, :115) says a counter alert can start a task and Event Viewer can run one when an event appears; the Microsoft page linked for Performance Monitor is about sending email. Skimmers rule out the built-in tools for the wrong reason.
Match the intro at line 352: say they keep no history across servers and send no alert that reaches you without a scheduled task or script.
Still open from earlier reviews
- 🟠 Warning · F3 · Install script downloads a
windows_x64MSI the releases do not publish ·apps/landing/src/pages/guides/_windows-server-monitoring/install.ps1:3
What was checked
otlp_httpandresource_detectionare the current spellings, as inlog-parsing.astro:519- Highlighter round-trips both scripts byte-for-byte (ran
bun -eon the head checkout) - Alert copy matches the UI:
Minimum samples,Aggregate,attr.<key>group-by,Stopped reporting>5m
e8d6165 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Annotations
Check notice on line 322 in apps/landing/src/pages/guides/windows-server-monitoring.astro
maple-review-bot / Maple / review
correctness: Takeaways say the built-in tools send no alerts, contradicting the table
The box says the built-in tools "send no alerts", but the Alerts column of the tools table (`windows-server-monitoring.astro:108`, `:115`) says a counter alert can start a task and Event Viewer can run one when an event appears; the Microsoft page linked for Performance Monitor is about sending email. Skimmers rule out the built-in tools for the wrong reason.