Repository navigation
fix(web): shortcuts survive the key-less autofill keydown; extension errors stay out of error tracking - #1971
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge
Filter logic is @maple/sdk-core's existing default filter, covered by a unit test and an end-to-end handler test.
no findings · tests covered · risk medium
Hotkey handlers now read the key through pressedKey, and the effect SDK's global handlers drop extension and ResizeObserver noise. It addresses both open issues: the 9 browser.uncaught_error "ResizeObserver loop" spans on flushable.js and the toLowerCase TypeError in time-range-picker.js (the only two .toLowerCase() call sites are both changed). The foldkit.crash schema-validation issues are untouched by this diff. Safe to merge.
isOpenKeyand the shell shortcuts read keys through the newpressedKey- effect-sdk's
error/unhandledrejectionhandlers drop extension andResizeObservernoise
Before merge
- Manual · Release
@maple-dev/effect-sdkwith the patch changeset somaple-webpicks up the filter
Production impact
Open errors in the changed files
| Issue | Service | Occurrences | File |
|---|---|---|---|
| Error | maple-web | 9 | packages/effect-sdk/src/client/flushable.ts |
| TypeError | maple-web | 3 | apps/web/src/page/kit/time-range-picker.ts |
After this merges, Maple checks whether they stop.
What was checked
- Filter reuses
makeErrorFilter's default patterns, matching only the message and the top frame URL (sdk-core/src/error-filters.ts:101-119) - No
.key.toLowerCase()call site remains underapps/weborpackages/uiat the head @maple/sdk-coreis bundled like@maple/browser; its root export imports no Node builtins
3dda4a7 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.