Skip to content

perf(landing): subset Geist and Geist Mono to what the site renders - #1995

Merged
Makisuo merged 2 commits into
mainfrom
perf/landing-font-subset
Oct 30, 2026
Merged

Makisuo merged 2 commits into
mainfrom
perf/landing-font-subset

fix(landing): read \u escapes in the font script as exactly four digits

97d9e82
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 1m 40s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Delta is a two-line escape-regex fix in a hand-run generator; the rest of the script is unchanged and the committed subsets still match it.
no findings · tests not needed · risk low

Since the last review only ESCAPE changed: \uXXXX now takes exactly four hex digits and \u{...} one to six, with codepoints past U+10FFFF dropped, which is what JS itself allows. The collected character set, so the committed subsets, are unchanged.

  • ESCAPE reads unbraced \u escapes as exactly four digits, braced ones as one to six
  • content() drops escaped codepoints above U+10FFFF instead of raising in chr()

Production impact

Production traffic of the changed files (last 7 days)
File Calls/day Busiest operations
apps/landing/src/layouts/DocsLayout.astro 33 GET /favicon.ico 33/day, 0.0% err
What was checked
  • a or b in content() picks the matched alternation group, so empty strings never reach int(..., 16) (subset-fonts.py:207, :228)
  • Core unicode-range at head still lists U+0009-000A, U+200B, U+2011, matching the ALIASES table (fonts.generated.css:13)
  • Font filenames the script writes match what FontPreloads.astro:5-6 and fonts.generated.css import

97d9e82 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.