Repository navigation
fix(web): infra meta lines end in an ellipsis instead of clipping the last item - #1997
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. One-line class change in a pure view helper; every metaLine caller traced, and plain-string last items keep their own truncate for the ellipsis.
1 note · tests not needed · risk low
Lets the last metaLine item shrink instead of staying shrink-0, so an overflowing infra sub-line ends in an ellipsis. Safe to merge; layout of non-overflowing lines is unchanged.
Findings
🔵 Note · F1 · Only plain-string last items get the new ellipsis; node items still clip
correctness · apps/web/src/page/infra/kit/meta-line.ts:35-38
Line 38 caps and truncates only plain strings, so a node last item shrinks without any truncate and the parent's overflow-hidden still cuts it mid-word — the new comment promises an ellipsis. The hosts sub-line's last item is platformLabel (infra/hosts/list/view-table.ts:101), so that table is unchanged.
Give the item wrapper `min-w-0`, and add `min-w-0 truncate` to `platformLabel`'s outer span so node last items ellipsize too.
What was checked
- Traced every
metaLinecaller: containers, pods, nodes, workloads, GCP, Cloudflare and security all pass a plain string last - Last item keeps the default
flex-shrink: 1; onlyshrink-0is removed, so short lines render exactly as before
50ab2fb · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Annotations
Check notice on line 38 in apps/web/src/page/infra/kit/meta-line.ts
maple-review-bot / Maple / review
correctness: Only plain-string last items get the new ellipsis; node items still clip
Line 38 caps and truncates only plain strings, so a node last item shrinks without any `truncate` and the parent's `overflow-hidden` still cuts it mid-word — the new comment promises an ellipsis. The hosts sub-line's last item is `platformLabel` (`infra/hosts/list/view-table.ts:101`), so that table is unchanged.