Skip to content

fix(web): infra meta lines end in an ellipsis instead of clipping the last item #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Makisuo merged 1 commit into from
Oct 30, 2026
Merged

fix(web): infra meta lines end in an ellipsis instead of clipping the last item #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/page/infra/kit/meta-line.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@
],
present.map((item, index) =>
h.span(
[h.Class("flex shrink-0 items-center gap-x-2")],
// The last item shrinks so an overflowing line ends in an ellipsis, not a clipped word.
[h.Class(cn("flex items-center gap-x-2", index === present.length - 1 ? "min-w-0" : "shrink-0"))],
[
...(index > 0 ? [h.span([h.Class("text-foreground-faint")], ["·"])] : []),
typeof item === "string" ? h.span([h.Class("max-w-[28ch] truncate")], [item]) : item,

Check notice on line 38 in apps/web/src/page/infra/kit/meta-line.ts

View check run for this annotation

Maple Review Bot / Maple / review

correctness: Only plain-string last items get the new ellipsis; node items still clip 

Line 38 caps and truncates only plain strings, so a node last item shrinks without any `truncate` and the parent's `overflow-hidden` still cuts it mid-word — the new comment promises an ellipsis. The hosts sub-line's last item is `platformLabel` (`infra/hosts/list/view-table.ts:101`), so that table is unchanged.
],
),
),
Expand Down
Loading