Skip to content

style(web): align the service page tabs - #2013

Merged
Makisuo merged 5 commits into
mainfrom
style/services-tab-consistency
Oct 31, 2026
Merged

Makisuo merged 5 commits into
mainfrom
style/services-tab-consistency

fix(web): a failed dependencies reload keeps the last rows on screen

eec3168
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 31, 2026 in 59s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Re-review of the two files changed since ccf26d5; the stale/loading/error branches are correct and pinned by scene tests.
no findings · tests covered · risk low

The files changed since the last review give the Dependencies tab a loading skeleton and a real error state, and keep its last rows when a reload fails. Both behaviours are pinned by scene tests; safe to merge.

  • dependenciesTab renders a skeleton while the read is in flight and errorState when a first read fails
  • A failed reload renders the retained rows through onStale instead of an empty table
What was checked
  • A window change is not rendered as stale rows: a retained-data failure lands as Failure (apps/web/src/data/keyed.ts:115)
  • barCell takes className, so the pr-4 p95 edge compiles (view-table-cells.ts:72)
  • The hidden Avg column is hidden on both the header and the cell (view-dependencies.ts:119, :159)

eec3168 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.