-
Notifications
You must be signed in to change notification settings - Fork 1
chore(stellar-wallet-snap): migration phase B - update tsconfig + align dependencise + update readme #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stellar-wallet-snap): migration phase B - update tsconfig + align dependencise + update readme #159
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| { | ||
| "name": "@metamask/stellar-wallet-snap", | ||
| "version": "0.0.1", | ||
| "description": "A Stellar wallet Snap.", | ||
| "description": "A Stellar wallet Snap", | ||
| "keywords": [ | ||
| "Ethereum", | ||
| "MetaMask" | ||
| ], | ||
| "license": "(MIT-0 OR Apache-2.0)", | ||
| "homepage": "https://github.com/MetaMask/internal-snaps/tree/main/packages/stellar-wallet-snap#readme", | ||
| "bugs": { | ||
| "url": "https://github.com/MetaMask/internal-snaps/issues" | ||
| }, | ||
| "license": "(MIT OR Apache-2.0)", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/MetaMask/snap-stellar-wallet.git" | ||
| "url": "https://github.com/MetaMask/internal-snaps.git" | ||
| }, | ||
| "files": [ | ||
| "dist/", | ||
|
|
@@ -43,28 +48,28 @@ | |
| "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch" | ||
| }, | ||
| "devDependencies": { | ||
| "@metamask/auto-changelog": "^6.1.0", | ||
| "@metamask/auto-changelog": "^6.1.1", | ||
| "@metamask/key-tree": "^10.1.1", | ||
| "@metamask/keyring-api": "^23.7.0", | ||
| "@metamask/keyring-snap-sdk": "^9.2.1", | ||
| "@metamask/snaps-cli": "^8.4.0", | ||
| "@metamask/snaps-jest": "^10.1.0", | ||
| "@metamask/snaps-sdk": "^11.1.0", | ||
| "@metamask/superstruct": "^3.2.1", | ||
| "@metamask/snaps-cli": "^8.4.1", | ||
| "@metamask/snaps-jest": "^10.2.0", | ||
| "@metamask/snaps-sdk": "^11.2.0", | ||
| "@metamask/superstruct": "^3.4.1", | ||
| "@metamask/utils": "^11.11.0", | ||
| "@stellar/stellar-sdk": "^15.0.1", | ||
| "@types/jest": "^30.0.0", | ||
| "async-mutex": "^0.5.0", | ||
| "bignumber.js": "^9.3.1", | ||
| "concurrently": "^10.0.3", | ||
| "dotenv": "^17.2.1", | ||
| "jest": "^30.0.3", | ||
| "jest": "30.0.3", | ||
| "jest-it-up": "^2.0.2", | ||
| "jest-transform-stub": "2.0.0", | ||
| "lodash": "^4.18.1", | ||
| "lodash": "^4.17.21", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. align with other snap, downgrade doesnt cause issue but 18.1 fix some security issue, which we should address in other PR
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of forcing this down, perhaps we can bump the other packages? |
||
| "oxfmt": "^0.45.0", | ||
| "qrcode-generator": "^2.0.4", | ||
| "ts-jest": "^29.4.11" | ||
| "ts-jest": "^29.4.1" | ||
| }, | ||
| "engines": { | ||
| "node": ">=20" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,39 +12,45 @@ const config: SnapConfig = { | |
| environment: { | ||
| ENVIRONMENT: process.env.ENVIRONMENT ?? '', | ||
| LOG_LEVEL: process.env.LOG_LEVEL ?? '', | ||
| RPC_URL_MAINNET: process.env.RPC_URL_MAINNET ?? '', | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adding prefix |
||
| HORIZON_URL_MAINNET: process.env.HORIZON_URL_MAINNET ?? '', | ||
| EXPLORER_MAINNET_BASE_URL: process.env.EXPLORER_MAINNET_BASE_URL ?? '', | ||
| RPC_URL_TESTNET: process.env.RPC_URL_TESTNET ?? '', | ||
| HORIZON_URL_TESTNET: process.env.HORIZON_URL_TESTNET ?? '', | ||
| EXPLORER_TESTNET_BASE_URL: process.env.EXPLORER_TESTNET_BASE_URL ?? '', | ||
| TRANSACTION_TIMEOUT: process.env.TRANSACTION_TIMEOUT ?? '', | ||
| TRANSACTION_POLLING_ATTEMPTS: | ||
| process.env.TRANSACTION_POLLING_ATTEMPTS ?? '', | ||
| TRACK_TRANSACTION_MAX_RESCHEDULES: | ||
| process.env.TRACK_TRANSACTION_MAX_RESCHEDULES ?? '', | ||
| STELLAR_RPC_URL_MAINNET: process.env.STELLAR_RPC_URL_MAINNET ?? '', | ||
| STELLAR_HORIZON_URL_MAINNET: process.env.STELLAR_HORIZON_URL_MAINNET ?? '', | ||
| STELLAR_EXPLORER_MAINNET_BASE_URL: | ||
| process.env.STELLAR_EXPLORER_MAINNET_BASE_URL ?? '', | ||
| STELLAR_RPC_URL_TESTNET: process.env.STELLAR_RPC_URL_TESTNET ?? '', | ||
| STELLAR_HORIZON_URL_TESTNET: process.env.STELLAR_HORIZON_URL_TESTNET ?? '', | ||
| STELLAR_EXPLORER_TESTNET_BASE_URL: | ||
| process.env.STELLAR_EXPLORER_TESTNET_BASE_URL ?? '', | ||
| STELLAR_TRANSACTION_TIMEOUT: process.env.STELLAR_TRANSACTION_TIMEOUT ?? '', | ||
| STELLAR_TRANSACTION_POLLING_ATTEMPTS: | ||
| process.env.STELLAR_TRANSACTION_POLLING_ATTEMPTS ?? '', | ||
| STELLAR_TRACK_TRANSACTION_MAX_RESCHEDULES: | ||
| process.env.STELLAR_TRACK_TRANSACTION_MAX_RESCHEDULES ?? '', | ||
| TOKEN_API_BASE_URL: process.env.TOKEN_API_BASE_URL ?? '', | ||
| STATIC_API_BASE_URL: process.env.STATIC_API_BASE_URL ?? '', | ||
| PRICE_API_BASE_URL: process.env.PRICE_API_BASE_URL ?? '', | ||
| SECURITY_ALERTS_API_BASE_URL: | ||
| process.env.SECURITY_ALERTS_API_BASE_URL ?? '', | ||
| FIAT_EXCHANGE_RATES_TTL_MILLISECONDS: | ||
| process.env.FIAT_EXCHANGE_RATES_TTL_MILLISECONDS ?? '', | ||
| HISTORICAL_PRICES_TTL_MILLISECONDS: | ||
| process.env.HISTORICAL_PRICES_TTL_MILLISECONDS ?? '', | ||
| SPOT_PRICES_TTL_MILLISECONDS: | ||
| process.env.SPOT_PRICES_TTL_MILLISECONDS ?? '', | ||
| BASE_FEE_TTL_MILLISECONDS: process.env.BASE_FEE_TTL_MILLISECONDS ?? '', | ||
| LOAD_ON_CHAIN_ACCOUNT_TTL_MILLISECONDS: | ||
| process.env.LOAD_ON_CHAIN_ACCOUNT_TTL_MILLISECONDS ?? '', | ||
| SIMULATE_TRANSACTION_TTL_MILLISECONDS: | ||
| process.env.SIMULATE_TRANSACTION_TTL_MILLISECONDS ?? '', | ||
| SEP41_ASSET_BALANCE_TTL_MILLISECONDS: | ||
| process.env.SEP41_ASSET_BALANCE_TTL_MILLISECONDS ?? '', | ||
| BASE_FEE_MULTIPLIER: process.env.BASE_FEE_MULTIPLIER ?? '', | ||
| MAX_FEE_THRESHOLD_IN_XLM: process.env.MAX_FEE_THRESHOLD_IN_XLM ?? '', | ||
| MAX_RECONCILE_ATTEMPTS: process.env.MAX_RECONCILE_ATTEMPTS ?? '', | ||
| MAX_PENDING_TRANSACTION_AGE: process.env.MAX_PENDING_TRANSACTION_AGE ?? '', | ||
| STELLAR_FIAT_EXCHANGE_RATES_TTL_MILLISECONDS: | ||
| process.env.STELLAR_FIAT_EXCHANGE_RATES_TTL_MILLISECONDS ?? '', | ||
| STELLAR_HISTORICAL_PRICES_TTL_MILLISECONDS: | ||
| process.env.STELLAR_HISTORICAL_PRICES_TTL_MILLISECONDS ?? '', | ||
| STELLAR_SPOT_PRICES_TTL_MILLISECONDS: | ||
| process.env.STELLAR_SPOT_PRICES_TTL_MILLISECONDS ?? '', | ||
| STELLAR_BASE_FEE_TTL_MILLISECONDS: | ||
| process.env.STELLAR_BASE_FEE_TTL_MILLISECONDS ?? '', | ||
| STELLAR_LOAD_ON_CHAIN_ACCOUNT_TTL_MILLISECONDS: | ||
| process.env.STELLAR_LOAD_ON_CHAIN_ACCOUNT_TTL_MILLISECONDS ?? '', | ||
| STELLAR_SIMULATE_TRANSACTION_TTL_MILLISECONDS: | ||
| process.env.STELLAR_SIMULATE_TRANSACTION_TTL_MILLISECONDS ?? '', | ||
| STELLAR_SEP41_ASSET_BALANCE_TTL_MILLISECONDS: | ||
| process.env.STELLAR_SEP41_ASSET_BALANCE_TTL_MILLISECONDS ?? '', | ||
| STELLAR_BASE_FEE_MULTIPLIER: process.env.STELLAR_BASE_FEE_MULTIPLIER ?? '', | ||
| STELLAR_MAX_FEE_THRESHOLD_IN_XLM: | ||
| process.env.STELLAR_MAX_FEE_THRESHOLD_IN_XLM ?? '', | ||
| STELLAR_MAX_RECONCILE_ATTEMPTS: | ||
| process.env.STELLAR_MAX_RECONCILE_ATTEMPTS ?? '', | ||
| STELLAR_MAX_PENDING_TRANSACTION_AGE: | ||
| process.env.STELLAR_MAX_PENDING_TRANSACTION_AGE ?? '', | ||
| }, | ||
| polyfills: true, | ||
| }; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| { | ||
| "extends": "../../tsconfig.packages.json", | ||
| "compilerOptions": { | ||
| "module": "preserve", | ||
| "moduleResolution": "bundler", | ||
| "target": "es2023", | ||
| "lib": ["ES2023", "DOM"], | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noErrorTruncation": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "resolveJsonModule": true, | ||
| "resolveJsonModule": true /* lets us import JSON modules from within TypeScript modules. */, | ||
| "jsx": "react-jsx", | ||
| "jsxImportSource": "@metamask/snaps-sdk", | ||
| "exactOptionalPropertyTypes": false, | ||
| "types": ["jest"], | ||
| "esModuleInterop": true, | ||
| "noEmit": true, | ||
| "strict": true | ||
| "forceConsistentCasingInFileNames": true, | ||
| "noErrorTruncation": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "skipLibCheck": true, | ||
| "lib": ["ES2023", "DOM"], | ||
| "target": "es2023", | ||
| "module": "preserve", | ||
| "moduleResolution": "bundler", | ||
| "types": ["jest"] | ||
| }, | ||
| "include": ["**/*.ts", "**/*.tsx", "locales/*.json"] | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by purpose not allign metamask/utils
stellar namespace is included in "@metamask/utils": "^11.11.0",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also bump the other packages to
^11.11.0instead of downgrading this one