chore(stellar-wallet-snap): migration phase B - update tsconfig + align dependencise + update readme - #159
Conversation
| "name": "@metamask/stellar-wallet-snap", | ||
| "version": "0.0.1", | ||
| "description": "A Stellar wallet Snap.", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
align initial version
There was a problem hiding this comment.
Hey @stanleyyconsensys so I just confirmed and this version should be left unchanged during the migration and then bumped as part of the initial release.
| "@metamask/snaps-jest": "^10.2.0", | ||
| "@metamask/snaps-sdk": "^11.2.0", | ||
| "@metamask/superstruct": "^3.4.1", | ||
| "@metamask/utils": "^11.11.0", |
There was a problem hiding this comment.
by purpose not allign metamask/utils
stellar namespace is included in "@metamask/utils": "^11.11.0",
There was a problem hiding this comment.
we could also bump the other packages to ^11.11.0 instead of downgrading this one
| environment: { | ||
| ENVIRONMENT: process.env.ENVIRONMENT ?? '', | ||
| LOG_LEVEL: process.env.LOG_LEVEL ?? '', | ||
| RPC_URL_MAINNET: process.env.RPC_URL_MAINNET ?? '', |
There was a problem hiding this comment.
adding prefix STELLAR to distinguish the CI env
stanleyyconsensys
changed the title
stanleyyconsensys
changed the title
| "jest-it-up": "^2.0.2", | ||
| "jest-transform-stub": "2.0.0", | ||
| "lodash": "^4.18.1", | ||
| "lodash": "^4.17.21", |
There was a problem hiding this comment.
align with other snap, downgrade doesnt cause issue
but 18.1 fix some security issue, which we should address in other PR
There was a problem hiding this comment.
instead of forcing this down, perhaps we can bump the other packages?
taran-a
left a comment
taran-a
left a comment
There was a problem hiding this comment.
LGTM. Just one point regarding LICENSE files. Could you please review other snaps as we have three files. Just to align with other snaps.
4 participants
Explanation
This PR is cover the migration all steps on phase B
[PR#6] Reset the CHANGELOG, linking back to the old repository (skip, stellar is new)
[PR#7] Remove files and directories replaced by the monorepo root (skip, done already)
[PR#8] Replace config files (included in PR)
[PR#9] Align dependencies and build scripts with the monorepo (included in PR)
[PR#10] Update the README to reflect non-root-package status (included in PR)
Migration process
References
Checklist