Skip to content

chore(stellar-wallet-snap): migration phase C - Integration Stellar into packages + Linter and constraints fixes + update changelog - #161

Merged
stanleyyconsensys merged 23 commits into
mainfrom
chore/stellar/migration-phase-c-2
Aug 18, 2026
Merged

chore(stellar-wallet-snap): migration phase C - Integration Stellar into packages + Linter and constraints fixes + update changelog #161
stanleyyconsensys merged 23 commits into
mainfrom
chore/stellar/migration-phase-c-2

Conversation

@stanleyyconsensys

@stanleyyconsensys stanleyyconsensys commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Explanation

This PR is cover the migration all steps on phase C

  • Move the package from merged-packages/ to packages/ (included in PR))

    • Move static tokens list from old repo
  • Linter and constraints fixes (include in the PR)

    • Bump Metamask/utils to 11.11.0 on all SNAP and Utils for constraints fix, as stellar require 11.11.0
  • Resolve or TODO downstream errors (nth to do)

  • Record changes in CHANGELOG [Unreleased] (included in the PR)

  • Finalize merge (done)

Migration process

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@stanleyyconsensys
stanleyyconsensys requested review from a team as code owners August 18, 2026 05:06
@socket-security

socket-security Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​qrcode-generator@​2.0.410010010081100
Addednpm/​@​stellar/​stellar-sdk@​15.1.09910010099100

View full report

@socket-security

socket-security Bot commented Aug 18, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/@stellar/stellar-sdk@15.1.0
  • npm/qrcode-generator@2.0.4
  • npm/@stellar/stellar-base@15.0.0
  • npm/eventsource@2.0.2
  • npm/feaxios@0.0.23
  • npm/toml@3.0.0
  • npm/urijs@1.19.11
  • npm/@stellar/js-xdr@4.0.0
  • npm/base32.js@0.1.0
  • npm/is-retry-allowed@3.0.0
  • npm/commander@14.0.3
  • npm/axios@1.15.0

View full report

Comment thread eslint.config.mjs
'jest/no-alias-methods': 'error',
'jest/no-commented-out-tests': 'error',
'jest/no-disabled-tests': 'error',
'jest/no-mocks-import': 'off',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stellar is import some test utils from mocks in Test file, skip this rule would not cause addtional eslint issue

@stanleyyconsensys

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore @stellar/stellar-sdk

@stanleyyconsensys

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@stanleyyconsensys

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all

@stanleyyconsensys stanleyyconsensys changed the title Chore/stellar/migration phase c 2 chore(stellar-wallet-snap): migration phase C - Integration Stellar into packages + Linter and constraints fixes + update changelog Aug 18, 2026
Comment thread package.json Outdated
"ripemd160@npm:^2.0.1": "2.0.2",
"ws@7.4.6": "^7.5.10"
"ws@7.4.6": "^7.5.10",
"@stellar/stellar-sdk/axios@npm:1.15.0": "1.18.1",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.15.0 has security concern, resolve to 1.18.1

@stanleyyconsensys

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-81372f8e
@metamask-previews/snap-networks-utils@1.0.0-preview-81372f8e
@metamask-previews/solana-wallet-snap@6.0.0-preview-81372f8e
@metamask-previews/stellar-wallet-snap@0.0.1-preview-81372f8e
@metamask-previews/tron-wallet-snap@3.1.0-preview-81372f8e

@taran-a

taran-a commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@stanleyyconsensys GG. Please try to run yarn typecheck script. It's not part of CI but I spotted many ts issue in other snaps after migration. I am curious if stellar is clean or has some.

@ulissesferreira

ulissesferreira commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Spotted one type problem in packages/stellar-wallet-snap/src/handlers/cronjob/refreshConfirmationContext/priceRefresher.ts

Screenshot 2026-08-18 at 11 06 56 Screenshot 2026-08-18 at 11 07 09

@ulissesferreira
ulissesferreira added this pull request to the merge queue Aug 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@ulissesferreira
ulissesferreira added this pull request to the merge queue Aug 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@stanleyyconsensys
stanleyyconsensys added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 58c8915 Aug 18, 2026
52 checks passed
@stanleyyconsensys
stanleyyconsensys deleted the chore/stellar/migration-phase-c-2 branch August 18, 2026 15:47
@stanleyyconsensys

Copy link
Copy Markdown
Contributor Author

Spotted one type problem in packages/stellar-wallet-snap/src/handlers/cronjob/refreshConfirmationContext/priceRefresher.ts

Screenshot 2026-08-18 at 11 06 56 Screenshot 2026-08-18 at 11 07 09

for reference, we will address it from other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants