Repository navigation
feat: add changesets changelog pull request resolver - #84
Merged
Merged
Conversation
| * @param subject - The Git commit subject. | ||
| * @returns The pull request number. | ||
| */ | ||
| export function extractPullRequestNumber(subject: string): string { |
Contributor
There was a problem hiding this comment.
do we need to export these at index.ts ?
export { extractPullRequestNumber, getPullRequestLink } from './resolve-pull-request.js';
Contributor
There was a problem hiding this comment.
All right it looks like from PR description this will come up in a future PR
Contributor
Author
There was a problem hiding this comment.
No these will only be used internally. this is the changesets plugin so I would keep the exports to only the plugin required functions (they'll come after)
cryptodev-2s
approved these changes
Oct 16, 2026
3 of 4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This is the first stacked PR for
@metamask/changesets-changelog. It adds the local Git commit-subject helper used to build pull request links.The helper runs
git show -s --format=%s <commit>and extracts pull request numbers from squash-merge subjects such asAdd a feature (#1234)and merge subjects such asMerge pull request #1234 from owner/branch. It does not call the GitHub API or require a token. It throws when commit metadata is missing, unreadable, empty, or does not contain a pull request number.The generated greeting placeholder is removed. Rendering exports will follow in later stacked PRs.
References
apply-release-plan#25Checklist