refactor(compute): unify gateway restart reconciliation - #2743
Open
drew wants to merge 3 commits into
Open
Conversation
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 14, 2026 01:29
6 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-2743.docs.buildwithfern.com/openshell |
8 tasks
drew
force-pushed
the
refactor/2417-unify-driver-restart/drew
branch
from
August 17, 2026 06:05
2f74bca to
a036b59
Compare
9 tasks
drew
force-pushed
the
refactor/2417-unify-driver-restart/drew
branch
from
August 19, 2026 01:26
b103f36 to
f8ce804
Compare
|
Label |
Remove the Docker-specific gateway shutdown cleanup and reconcile persisted running intent through ComputeDriver::StartSandbox for Docker, Podman, and VM drivers. Explicitly stopped sandboxes remain stopped. Closes #2417 Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
refactor/2417-unify-driver-restart/drew
branch
from
August 19, 2026 04:09
f8ce804 to
9cad488
Compare
Collaborator
Author
|
/ok to test 9cad488 |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify graceful gateway shutdown and startup for local compute through the public
ComputeDriverlifecycle RPCs. Shutdown callsStopSandboxfor running-intent Docker, Podman, and VM sandboxes without persisting an explicit user stop; startup calls the idempotentStartSandboxRPC for that retained intent. Kubernetes remains cluster-owned.Related Issue
Part of #2417
Changes
ComputeDriver::StopSandboxduring graceful gateway shutdownopenshell sandbox stopComputeDriver::StartSandboxbefore startup watch processingTesting
mise run pre-commitcargo test -p openshell-server shutdown_stop_sweep --libcargo test -p openshell-server start_persisted_sandboxes --libOPENSHELL_E2E_DOCKER_TEST=gateway_start mise run e2e:dockermise run test: all completed suites passed except the unrelatedgateway_completer_returns_empty_when_no_config, which reproduces in isolation because this host has registered system gateway configurationChecklist