Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Do we still need the special handling that strips
|
|
Before I arrived at the question posted in #2919 (comment), I had the considerations below. They will be moot if we go ahead with removing the The existing custom regex is doing two jobs at once:
As a defense mechanism, however, it is imperfect. The expression is anchored at the beginning but not at the end, so it can silently accept only a prefix of an unexpected tag. For example, an unrecognized suffix can be discarded and the tag reinterpreted as an apparently valid version instead of being rejected. The allowlist also obscures the actual mapping policy and requires us to extend the regex whenever we introduce another legitimate suffix, as this PR does for I therefore have doubts about piggy-backing validation onto the regex when the intended special behavior is simply “strip a terminal |
WIP / TODO