Repository navigation
Initial lambda extraction - #566
Conversation
d37b5c3 to
3b7ed08
Compare
8523e16 to
1c5cb77
Compare
|
I am marking this as ready for review, so that we can determine remaining priorities before release. Let me know if this is worth it before release |
nkoukpaizan
left a comment
There was a problem hiding this comment.
I like the idea of extracting the lambda. What we need to discuss is where the extracted methods will live.
superwhiskers
left a comment
There was a problem hiding this comment.
some quick comments. overall seems like a good change to make
10d8a1a to
11adb87
Compare
|
I have not addressed every review comment but I have made larger cleanup and improvement, I think it's in the right direction. |
cde1e6a to
6970b6d
Compare
72a0648 to
6fb3a2d
Compare
|
@superwhiskers @nkoukpaizan I applied all suggested changes and also shrunk size of the PR, so its more reviewable. I only migrated |
880ff13 to
da64037
Compare
|
@superwhiskers rebased and all suggestions applied! |
superwhiskers
left a comment
There was a problem hiding this comment.
all tests pass on my machine. should be good to merge
pelesh
left a comment
There was a problem hiding this comment.
Looks good.
Introducing default for verify() method in the base class will allow developers to implement component models without verify(). Do we want to nudge every component model developer to add verification checks? Are there components where there is nothing to verify?
|
@pelesh Ready!! |
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
8a4dbbb to
fdff03b
Compare
|
And rebased |
Description
Replace the per-model parameter-parsing and configuration-check lambdas with extracted helpers.
Proposed changes
Model::ConfigurationChecks:verify()returns every configuration problem as a message, prefixed with the model name, instead of an error count. Applied to all components.Model::ParameterReader:loadReal,loadNonNegative,loadBool,loadInteger,requireReal,requireBool. Invalid model data throwsstd::invalid_argumentnaming the model and parameter.Testing::configurationRejectedfor tests that expect rejection at construction or byverify().ParameterReader.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None.