[Mattias-Sehlstedt]

PR checklist

The pekko sample generation does not pin its sbt version, which leads to it being resolved to v2, which required JDK 17. The pipeline uses JDK 11. Spotted as an issue in #25383.

I have updated the samples to mimic what exists for akka, where the version is pinned to 1.x.

• Read the contribution guidelines.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/server/petstore/scala-pekko-http-server/project/build.properties">

<violation number="1" location="samples/server/petstore/scala-pekko-http-server/project/build.properties:1">
P2: This pin is only in the sample. The generator (`ScalaAkkaHttpServerCodegen`) never emits `project/build.properties`, so generated pekko server projects still resolve sbt to v2. Add `new SupportingFile("project/build.properties.mustache", "project", "build.properties")` with the pinned version in the codegen, and template it, so regeneration reproduces this file.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic</sub>

[cubic-dev-ai]

P2: This pin is only in the sample. The generator (ScalaAkkaHttpServerCodegen) never emits project/build.properties, so generated pekko server projects still resolve sbt to v2. Add new SupportingFile("project/build.properties.mustache", "project", "build.properties") with the pinned version in the codegen, and template it, so regeneration reproduces this file.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/server/petstore/scala-pekko-http-server/project/build.properties, line 1:

<comment>This pin is only in the sample. The generator (`ScalaAkkaHttpServerCodegen`) never emits `project/build.properties`, so generated pekko server projects still resolve sbt to v2. Add `new SupportingFile("project/build.properties.mustache", "project", "build.properties")` with the pinned version in the codegen, and template it, so regeneration reproduces this file.</comment>

<file context>
@@ -0,0 +1 @@
+sbt.version=1.10.11
</file context>

[Mattias-Sehlstedt]

The pin is intentionally only for the sample, so yes generated samples may resolve to the higher version (and thus not work with JDK 11)