Skip to content

ci: set SBT version to 1.10.11 for scala pekko #25390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Oct 24, 2026
+1 −0
Merged

ci: set SBT version to 1.10.11 for scala pekko #25390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/server/petstore/scala-pekko-http-server/project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
sbt.version=1.10.11

@cubic-dev-ai cubic-dev-ai Bot Oct 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This pin is only in the sample. The generator (ScalaAkkaHttpServerCodegen) never emits project/build.properties, so generated pekko server projects still resolve sbt to v2. Add new SupportingFile("project/build.properties.mustache", "project", "build.properties") with the pinned version in the codegen, and template it, so regeneration reproduces this file.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At samples/server/petstore/scala-pekko-http-server/project/build.properties, line 1:

<comment>This pin is only in the sample. The generator (`ScalaAkkaHttpServerCodegen`) never emits `project/build.properties`, so generated pekko server projects still resolve sbt to v2. Add `new SupportingFile("project/build.properties.mustache", "project", "build.properties")` with the pinned version in the codegen, and template it, so regeneration reproduces this file.</comment>

<file context>
@@ -0,0 +1 @@
+sbt.version=1.10.11
</file context>

@Mattias-Sehlstedt Mattias-Sehlstedt Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin is intentionally only for the sample, so yes generated samples may resolve to the higher version (and thus not work with JDK 11)

Loading