Repository navigation
xm: probe for ImageDesign (MIS) sensors - #252
Merged
Merged
Conversation
The XM HAL listed no ImageDesign address, so detect_imagedesign_sensor never ran on Xiongmai and a MIS2003 board reported no sensor at all: the WebUI showed "unknown". libsns_X123_XM530 finds MIS2003/MIS2006 at 0x30 (0x60 8-bit), reading the ID from 0x3000/0x3001, which is what detect_imagedesign_sensor already does. Reported in OpenIPC/openxiongmai#8.
PR Summary by Qodoxm: enable ImageDesign MIS sensor detection
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can move or hide resolved findings to focus on what still needs action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Xiongmai,
ipcinfo --short-sensorprints nothing for a MIS2003 board, so the WebUI shows the sensor as unknown (OpenIPC/openxiongmai#8).The XM HAL's
xm_possible_i2c_addrshas noSENSOR_IMAGEDESIGNentry, sodetect_imagedesign_sensornever runs on XM.libsns_X123_XM530finds MIS2003/MIS2006 at 0x30 (0x60 in the 8-bit form this table uses) and reads the ID from 0x3000/0x3001, which is exactly whatdetect_imagedesign_sensoralready does. This adds the address. clang-format reflows the table once the line gets longer.Tested
ipcinfofrom this branch (arm-openipc-linux-musleabi gcc 13):xm530machine with an emulated MIS2003 (ID 0x2003 at 0x30), bootingnightly-20261016-2a2e35c:load_xiongmaikeeps choosinglibsns_X123_XM530: onlyimx335/sc335emap to X50.cYAML_testpasses.The UPX-packed build couldn't be tried on the camera: the local UPX 5 stub needs
memfd_create, which this 3.10 kernel doesn't have. That's separate from this change.