Repository navigation
Installation works in a new project; URP only - #50
Merged
Merged
Conversation
… define or built-in default material The bug report says Chisel needs URP instead of asking which pipeline is used; the core assembly's USING_URP and USING_HDRP defines were never used, and neither was SceneHandleMaterialManager.DefaultMaterial (a built-in material).
… uGUI ChiselGlobal.cs had an unused using UnityEngine.UI, so the package didn't compile in a project without com.unity.ugui.
…carded logger Passing NativeList.Length straight into the [BurstDiscard] LogInconsistentVertexStreams made Burst warn (BC1371) that the calls were discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested as a new user would: a fresh Unity 6.6 project with only URP, Chisel added by git URL.
Installation
ChiselGlobal.cshad an unusedusing UnityEngine.UI;, and the package doesn't depend on uGUI. Removed.NativeList.Lengthwas passed straight into a[BurstDiscard]logger inChiselBrushRenderBuffer. The lengths are now taken first.After these: 0 compile errors, 0 warnings from Chisel, 0 Burst warnings, Unity exits cleanly.
URP only
USING_URP/USING_HDRPdefines (never used) andSceneHandleMaterialManager.DefaultMaterial(an unused built-in material with a "make this work with HDRP" TODO).