Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ body:
attributes:
value: |
Thanks for reporting a problem! A scene that shows it, or steps to make it happen, helps us fix it much faster.

Chisel needs Unity 6.6 or newer and the Universal Render Pipeline (URP); other render pipelines aren't supported.
- type: textarea
id: what
attributes:
Expand Down Expand Up @@ -50,16 +52,6 @@ body:
description: The version in the Package Manager, or the commit you installed.
validations:
required: true
- type: dropdown
id: pipeline
attributes:
label: Render pipeline
options:
- URP
- HDRP
- Built-in
validations:
required: true
- type: input
id: platform
attributes:
Expand Down
6 changes: 3 additions & 3 deletions Core/2.Processing/Jobs/JobData/ChiselBrushRenderBuffer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@ public void Construct(BlobBuilder builder,
SurfaceDestinationParameters destinationParameters,
SurfaceOutputFlags outputFlags)
{
if (colliderVertices.Length != renderVertices.Length ||
colliderVertices.Length != selectVertices.Length)
int colliderCount = colliderVertices.Length, selectCount = selectVertices.Length, renderCount = renderVertices.Length, indexCount = indices.Length;
if (colliderCount != renderCount || colliderCount != selectCount)
{
LogInconsistentVertexStreams(surfaceIndex, colliderVertices.Length, selectVertices.Length, renderVertices.Length, indices.Length);
LogInconsistentVertexStreams(surfaceIndex, colliderCount, selectCount, renderCount, indexCount);

this.surfaceIndex = surfaceIndex;
this.baseSurfaceIndex = baseSurfaceIndex;
Expand Down
13 changes: 1 addition & 12 deletions Core/com.chisel.core.asmdef
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,6 @@
],
"autoReferenced": true,
"defineConstraints": [],
"versionDefines": [
{
"name": "com.unity.render-pipelines.universal",
"expression": "0.0.0",
"define": "USING_URP"
},
{
"name": "com.unity.render-pipelines.high-definition",
"expression": "0.0.0",
"define": "USING_HDRP"
}
],
"versionDefines": [],
"noEngineReferences": false
}
1 change: 0 additions & 1 deletion Editor/SceneView/Overlays/ChiselGlobal.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using UnityEditor.Overlays;
using UnityEditor.Toolbars;
using UnityEngine;
using UnityEngine.UI;

// Just a misc. collections of buttons we don't have a more sensible place for
namespace Chisel.Editors
Expand Down
12 changes: 0 additions & 12 deletions Editor/SceneView/Visualization/SceneHandleMaterialManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,6 @@ static void ShaderInit()
s_LineAlphaMultiplierId = Shader.PropertyToID("_alphaMultiplier");
}

static Material s_DefaultMaterial;
public static Material DefaultMaterial
{
get
{
// TODO: make this work with HDRP
if (!s_DefaultMaterial)
s_DefaultMaterial = AssetDatabase.GetBuiltinExtraResource<Material>("Default-Diffuse.mat");
return s_DefaultMaterial;
}
}

public static void InitGenericLineMaterial(Material genericLineMaterial)
{
if (!genericLineMaterial)
Expand Down
8 changes: 8 additions & 0 deletions INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,12 @@ needs to be installed and on your path.
The first time you start up it might take some time, because Unity Burst compiles a lot of code.
This should only happen once.

### If the installation fails

* **"Filename too long"** (Windows): git can't write the dependencies inside a deep project folder. Allow long
paths in git once, with `git config --global core.longpaths true`, or move the project to a shorter path, then
install again.
* **"Cannot checkout repository"**: make sure git is installed and that `git` works in a command prompt; Unity uses
it to download Chisel and its dependencies.

Then see [Getting Started](GETTING_STARTED.md).
Loading