Skip to content

Name the builds "build" in the Actions list; remove orphaned config and stale comments; short MSVC object paths for rosbag2_performance_benchmarking_msgs - #134

Open
Tobias-Fischer wants to merge 6 commits into
mainfrom
build-workflow-name
Open

Tobias-Fischer wants to merge 6 commits into
mainfrom
build-workflow-name

Conversation

@Tobias-Fischer

@Tobias-Fischer Tobias-Fischer commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Housekeeping, plus a Windows path-length fix.

Actions list name. GitHub names a workflow path from the default branch's file. main has no .github/workflows/build.yaml (only the buildbranch_<distro>_<platform> branches carry the real one), so the Actions list showed one of those, e.g. "jazzy build_linux64", for every distribution's builds. A placeholder build.yaml on main named build, which is never triggered on its own, fixes the name for all of them.

Orphaned configuration. Removed entries for packages that are in neither the distribution's snapshot nor its pending sync snapshot:

  • shared/vinca.yaml packages_select_by_deps: autoware_lanlet2_utils (a typo duplicate of autoware_lanelet2_utils), robot, teleop, dev_tools, rclcpp_async, cl_ros2_timer, avt_vimba_camera_msgs;
  • patch/dependencies.yaml:
    • shared: embree_vendor, ign_rviz*, ros1_rosbag_storage_vendor, rosbag2_bag_v2_plugins;
    • humble: mrpt2;
    • jazzy: mrpt2 and the ros_ign_* entries;
    • lyrical: those, plus grid_map_octomap;
    • rolling: the same as jazzy (slam_toolbox and grid_map_octomap are only temporarily missing from rolling, so their overrides stay);
  • pkg_additional_info.yaml:
    • jazzy: ignition_*_vendor;
    • lyrical and rolling: hpp_fcl, octomap;
  • humble's test_ros_gz_bridge exclude;
  • humble's four unused *.emscripten.patch files.

Comments.

  • The orphaned tl_expected/sophus comment above packages_select_by_deps now sits at the robostack.yaml mappings it describes, with what it means: mapping the keys to conda-forge makes every dependent use conda-forge's build, and the ROS packages themselves are never built.
  • vinca.yaml loses the "requested in" links, attributions and duplicated halves of merged comments.
  • It also loses platform-failure notes for packages that now build there. I checked each against the jazzy and humble channels: foxglove_bridge, gtsam, joy_linux, libg2o, moveit_runtime, robot_localization, ros_gz_interfaces, ublox and others.

Windows path length. rosbag2_performance_benchmarking_msgs failed the jazzy and lyrical win-64 build branches with MSVC C1083: Cannot open compiler generated file: '': its generated type-support object paths exceed 260 characters. It now passes -DCMAKE_INTERMEDIATE_DIR_STRATEGY=SHORT on Windows, which names intermediate directories and object files by short hashes (CMake ≥ 4.2; the builds use 4.4.4). It has to be a CMake argument, because rattler-build doesn't pass the environment variable through to the build script. If this works, the same flag could replace the Windows exclusions of autoware_internal_localization_msgs and iiwa14_moveit_config (same error), or go into vinca's bld_ament_cmake.bat.in for every package.

rs check and the 45 tool tests pass. The generated jazzy win-64 recipe of rosbag2_performance_benchmarking_msgs has the flag.

The post-merge jazzy and lyrical win-64 builds are the real test of the path-length fix.

🤖 Claude (AI assistant), on behalf of @Tobias-Fischer

🤖 Generated with Claude Code

Tobias-Fischer and others added 6 commits October 22, 2026 08:49
…"build"

GitHub shows one workflow per path and names it from the default branch's
file. build.yaml only existed on the build branches, so the list kept the
name of the first branch that registered the path ("jazzy build_linux64").
The placeholder has only a manual trigger and a no-op step; the build
branches keep their own generated build.yaml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ping

Drop entries for packages that are in neither the distro's snapshot nor its
pending sync snapshot: dead packages_select_by_deps seeds (incl. the
autoware_lanlet2_utils typo duplicate), dependencies.yaml and
pkg_additional_info.yaml entries, and humble's test_ros_gz_bridge exclude.

Move the orphaned tl_expected/sophus comment from vinca.yaml to the
robostack.yaml mappings it actually describes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ten patches

Remove platform-failure notes for packages that now build there (checked
against the jazzy/humble channels: foxglove_bridge, gtsam, joy_linux, libg2o,
moveit_runtime, robot_localization, ros_gz_interfaces, ublox, ...), all
"requested in" links, and duplicated halves of merged comments.

humble's *.emscripten.patch files are unused here (no emscripten platform).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on Windows

The object file paths of its generated type support exceed MSVC's 260
characters (C1083: Cannot open compiler generated file: ''), failing the
jazzy and lyrical win-64 builds. CMAKE_INTERMEDIATE_DIR_STRATEGY=SHORT
(CMake >= 4.2; the builds use 4.4) names them by short hashes. It has to be
a CMake argument: rattler-build doesn't pass the environment variable
through to the build script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both are only temporarily missing from rolling (lyrical, branched from it,
has them), so their overrides stay for when they're released again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant