Repository navigation
Name the builds "build" in the Actions list; remove orphaned config and stale comments; short MSVC object paths for rosbag2_performance_benchmarking_msgs - #134
Open
Tobias-Fischer wants to merge 6 commits into
Conversation
…"build"
GitHub shows one workflow per path and names it from the default branch's
file. build.yaml only existed on the build branches, so the list kept the
name of the first branch that registered the path ("jazzy build_linux64").
The placeholder has only a manual trigger and a no-op step; the build
branches keep their own generated build.yaml.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ping Drop entries for packages that are in neither the distro's snapshot nor its pending sync snapshot: dead packages_select_by_deps seeds (incl. the autoware_lanlet2_utils typo duplicate), dependencies.yaml and pkg_additional_info.yaml entries, and humble's test_ros_gz_bridge exclude. Move the orphaned tl_expected/sophus comment from vinca.yaml to the robostack.yaml mappings it actually describes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ten patches Remove platform-failure notes for packages that now build there (checked against the jazzy/humble channels: foxglove_bridge, gtsam, joy_linux, libg2o, moveit_runtime, robot_localization, ros_gz_interfaces, ublox, ...), all "requested in" links, and duplicated halves of merged comments. humble's *.emscripten.patch files are unused here (no emscripten platform). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on Windows The object file paths of its generated type support exceed MSVC's 260 characters (C1083: Cannot open compiler generated file: ''), failing the jazzy and lyrical win-64 builds. CMAKE_INTERMEDIATE_DIR_STRATEGY=SHORT (CMake >= 4.2; the builds use 4.4) names them by short hashes. It has to be a CMake argument: rattler-build doesn't pass the environment variable through to the build script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both are only temporarily missing from rolling (lyrical, branched from it, has them), so their overrides stay for when they're released again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
force-pushed
the
build-workflow-name
branch
from
October 22, 2026 01:49
0d3d039 to
ac662a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping, plus a Windows path-length fix.
Actions list name. GitHub names a workflow path from the default branch's file.
mainhas no.github/workflows/build.yaml(only thebuildbranch_<distro>_<platform>branches carry the real one), so the Actions list showed one of those, e.g. "jazzy build_linux64", for every distribution's builds. A placeholderbuild.yamlonmainnamedbuild, which is never triggered on its own, fixes the name for all of them.Orphaned configuration. Removed entries for packages that are in neither the distribution's snapshot nor its pending sync snapshot:
shared/vinca.yamlpackages_select_by_deps:autoware_lanlet2_utils(a typo duplicate ofautoware_lanelet2_utils),robot,teleop,dev_tools,rclcpp_async,cl_ros2_timer,avt_vimba_camera_msgs;patch/dependencies.yaml:embree_vendor,ign_rviz*,ros1_rosbag_storage_vendor,rosbag2_bag_v2_plugins;mrpt2;mrpt2and theros_ign_*entries;grid_map_octomap;slam_toolboxandgrid_map_octomapare only temporarily missing from rolling, so their overrides stay);pkg_additional_info.yaml:ignition_*_vendor;hpp_fcl,octomap;test_ros_gz_bridgeexclude;*.emscripten.patchfiles.Comments.
packages_select_by_depsnow sits at therobostack.yamlmappings it describes, with what it means: mapping the keys to conda-forge makes every dependent use conda-forge's build, and the ROS packages themselves are never built.vinca.yamlloses the "requested in" links, attributions and duplicated halves of merged comments.Windows path length.
rosbag2_performance_benchmarking_msgsfailed the jazzy and lyrical win-64 build branches with MSVCC1083: Cannot open compiler generated file: '': its generated type-support object paths exceed 260 characters. It now passes-DCMAKE_INTERMEDIATE_DIR_STRATEGY=SHORTon Windows, which names intermediate directories and object files by short hashes (CMake ≥ 4.2; the builds use 4.4.4). It has to be a CMake argument, because rattler-build doesn't pass the environment variable through to the build script. If this works, the same flag could replace the Windows exclusions ofautoware_internal_localization_msgsandiiwa14_moveit_config(same error), or go into vinca'sbld_ament_cmake.bat.infor every package.rs checkand the 45 tool tests pass. The generated jazzy win-64 recipe ofrosbag2_performance_benchmarking_msgshas the flag.The post-merge jazzy and lyrical win-64 builds are the real test of the path-length fix.
🤖 Claude (AI assistant), on behalf of @Tobias-Fischer
🤖 Generated with Claude Code