[E2E][Bug] fix flaky E2E order confirmation detection - #764
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Assisted-By: devx/c44b22ed-e92b-422a-8245-d34957f21f33
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The required E2E gate intermittently closed checkout before order completion and then failed because the host cart had not been cleared.
BrowserStack command logs showed the existing broad completion regex returning only 250 ms after
Pay now, while the payment spinner was still visible. The test then tapped the checkout close button. Later passing runs using the exact same APK and journey waited 976 ms and 4.8 seconds for the real confirmation state before closing.Fix
Match complete order-confirmation headings instead of arbitrary text containing
Thank you,Your order,Order confirmed, orconfirmation.Both shared order journeys now accept only:
How to test
GIVEN the PR's Kotlin Android
checkout-guestBrowserStack journey has submitted paymentWHEN the reviewer watches the journey recording from the
Pay nowaction through checkout closingTHEN checkout should remain open while payment is processing and close only after the order-confirmation heading appears
AND the host app should show an empty cart after checkout closes
GIVEN the PR's hardcoded-buyer-identity BrowserStack journey has submitted payment
WHEN the reviewer watches the journey recording from the final submit action through checkout closing
THEN checkout should remain open until a complete order-confirmation heading appears
AND the host app should show an empty cart after checkout closes
Evidence