Skip to content

Default to pnpm/pnpx internally#7254

Merged
gonzaloriestra merged 1 commit intomainfrom
default-to-pnpm-internally
Apr 14, 2026
Merged

Default to pnpm/pnpx internally#7254
gonzaloriestra merged 1 commit intomainfrom
default-to-pnpm-internally

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Apr 13, 2026

WHY are these changes introduced?

We should align internal tooling with the repo’s default package manager (pnpm), so contributors and CI use the same commands.

WHAT is this pull request doing?

  • Root create-app script: Passes --package-manager pnpm into the create-app dev entrypoint.
  • E2E: Default packageManager in packages/e2e/setup/app.ts is pnpm when E2E_PACKAGE_MANAGER is unset; Playwright steps in tests-pr.yml use pnpm exec playwright so CI uses the workspace’s pinned Playwright (avoids pnpx pulling a different version). E2E helper script comments / create-app flows updated for pnpm where relevant.
  • Misc: Small script and workflow/doc tweaks (e.g. dev.yml, build-dev-docs.sh, create-notification-pr.js, release.yml) for consistency with pnpm-first usage.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

gonzaloriestra commented Apr 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review April 13, 2026 11:17
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 13, 2026 11:17
@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

This comment was marked as outdated.

@gonzaloriestra gonzaloriestra force-pushed the default-to-pnpm-internally branch from e714568 to 911892d Compare April 13, 2026 11:35
@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/node-package-manager.d.ts
@@ -60,6 +60,10 @@ export declare class FindUpAndReadPackageJsonNotFoundError extends BugError {
 export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): PackageManager;
 /**
  * Returns the dependency manager used in a directory.
+ * Walks upward from  so workspace packages (e.g. )
+ * still resolve to the repo root lockfile ().
+ * If no lockfile is found, it falls back to the package manager from the user agent.
+ * If the package manager from the user agent is unknown, it returns 'npm'.
  * @param fromDirectory - The starting directory
  * @returns The dependency manager
  */

@github-actions
Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260413113709

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Base automatically changed from fix-get-package-manager-workspaces to main April 13, 2026 12:42
@gonzaloriestra gonzaloriestra force-pushed the default-to-pnpm-internally branch from 911892d to 8ee5972 Compare April 14, 2026 10:00
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 24b6476 Apr 14, 2026
25 checks passed
@gonzaloriestra gonzaloriestra deleted the default-to-pnpm-internally branch April 14, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants