Skip to content

[Tests] Remove filesystem mocks in result.test.ts#7742

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-store-result-3233301235182325625
Open

[Tests] Remove filesystem mocks in result.test.ts#7742
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-store-result-3233301235182325625

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Follow the instructions from .agents/automated-tasks/tests.md to remove filesystem mocks.

WHAT is this pull request doing?

Refactor packages/store/src/cli/services/store/execute/result.test.ts to replace vi.mock('@shopify/cli-kit/node/fs') with real filesystem operations using inTemporaryDirectory and readFile.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 3233301235182325625 started by @gonzaloriestra

Refactor packages/store/src/cli/services/store/execute/result.test.ts to
replace vi.mock('@shopify/cli-kit/node/fs') with real filesystem
operations using inTemporaryDirectory and readFile. This ensures the
actual fs calls are functional and improves test reliability.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 8, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jun 9, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review June 9, 2026 10:21
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner June 9, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant