Skip to content

[Tests] Remove filesystem mocks in result.test.ts #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Tests] Remove filesystem mocks in result.test.ts #7742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions packages/store/src/cli/services/store/execute/result.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {writeOrOutputStoreExecuteResult} from './result.js'
import {afterEach, beforeEach, describe, expect, test, vi} from 'vitest'
import {writeFile} from '@shopify/cli-kit/node/fs'
import {inTemporaryDirectory, readFile} from '@shopify/cli-kit/node/fs'
import {joinPath} from '@shopify/cli-kit/node/path'
import {renderSuccess} from '@shopify/cli-kit/node/ui'
import {mockAndCaptureOutput} from '@shopify/cli-kit/node/testing/output'

vi.mock('@shopify/cli-kit/node/fs')
vi.mock('@shopify/cli-kit/node/ui')

function captureStandardStreams() {
Expand Down Expand Up @@ -42,12 +42,19 @@ describe('writeOrOutputStoreExecuteResult', () => {
})

test('writes results to a file when outputFile is provided', async () => {
await writeOrOutputStoreExecuteResult({data: {shop: {name: 'Test shop'}}}, '/tmp/results.json')

expect(writeFile).toHaveBeenCalledWith('/tmp/results.json', expect.stringContaining('Test shop'))
expect(renderSuccess).toHaveBeenCalledWith({
headline: 'Operation succeeded.',
body: 'Results written to /tmp/results.json',
await inTemporaryDirectory(async (tmpDir) => {
// Given
const outputFile = joinPath(tmpDir, 'results.json')

// When
await writeOrOutputStoreExecuteResult({data: {shop: {name: 'Test shop'}}}, outputFile)

// Then
await expect(readFile(outputFile)).resolves.toContain('Test shop')
expect(renderSuccess).toHaveBeenCalledWith({
headline: 'Operation succeeded.',
body: `Results written to ${outputFile}`,
})
})
})

Expand Down Expand Up @@ -86,9 +93,16 @@ describe('writeOrOutputStoreExecuteResult', () => {
})

test('suppresses success rendering when writing a file in json mode', async () => {
await writeOrOutputStoreExecuteResult({data: {shop: {name: 'Test shop'}}}, '/tmp/results.json', 'json')
await inTemporaryDirectory(async (tmpDir) => {
// Given
const outputFile = joinPath(tmpDir, 'results.json')

expect(writeFile).toHaveBeenCalledWith('/tmp/results.json', expect.stringContaining('Test shop'))
expect(renderSuccess).not.toHaveBeenCalled()
// When
await writeOrOutputStoreExecuteResult({data: {shop: {name: 'Test shop'}}}, outputFile, 'json')

// Then
await expect(readFile(outputFile)).resolves.toContain('Test shop')
expect(renderSuccess).not.toHaveBeenCalled()
})
})
})
Loading