Skip to content

Add published debugger runtime settings - #160

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-storage-inspectorfrom
bjd/debugger-settings
Draft

Add published debugger runtime settings#160
bjdodson-openai wants to merge 1 commit into
bjd/debugger-storage-inspectorfrom
bjd/debugger-settings

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Publishes renderer debug settings and native-appearance settings with explicit precedence and lifecycle behavior.

  • Keeps settings tied to concrete renderers and preserves replacement/disposal semantics.
  • Projects select values and provenance without triggering fallback getters prematurely.
  • Adds multi-root, replacement, precedence, and debug-gating coverage.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new debugger capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Incremental branch: Focused settings/runtime smoke, TypeScript, Prettier, terminology, and diff checks passed.
  • Assembled debugger stack: npm test passed 436/436; the CLI production build passed.
  • Focused //src/valdi_modules/src/valdi/web_renderer:test passed.
  • bazel query //... passed.
  • The broad Valdi suite reproduced the established 12 unrelated failures; all new debugger specs passed.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Stack 7/22. Stacked on #159 (bjd/debugger-storage-inspector). Review this PR as the single incremental commit 0a536a4c against that base; do not merge it before its parent.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

Total changes: 1584 lines (6 files)

Top files changed:

  • src/valdi_modules/src/valdi/valdi_core/test/DebugSettings.spec.ts: +639 -0
  • src/valdi_modules/src/valdi/valdi_core/src/debugging/DebugSettings.ts: +426 -0
  • src/valdi_modules/src/valdi/valdi_core/test/NativeAppearanceDebugSettings.spec.ts: +281 -0
  • src/valdi_modules/src/valdi/valdi_core/src/debugging/NativeAppearanceDebugSettings.ts: +175 -0
  • src/valdi_modules/src/valdi/valdi_core/src/Renderer.ts: +44 -12
  • src/valdi_modules/src/valdi/valdi_core/src/RootComponentsManager.ts: +7 -0

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
Valdi Smoke Tests ✅ success
macOS: C++ & Platform Tests ❌ failure
Snapshot Tests ✅ success
API Surface Check ✅ success
valdi_web Integration Test ✅ success
Linux: Module Tests ✅ success
Linux: Registry Validation ✅ success
Test Coverage Delta ✅ success
Linux: Hotreload Smoke ✅ success
Linux: Build & Export ✅ success
Linux: C++ Tests ✅ success
Linux: Build Compiler ✅ success

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant