Stop passing --lazy-mode to the coana CLI - #336
Merged
Conversation
The coana CLI no longer accepts --lazy-mode, so a reachability run started with --reach-lazy-mode failed on an unrecognized argument. --reach-lazy-mode is kept as a hidden no-op, matching how --reach-disable-analysis-splitting was deprecated, so pipelines that still pass it keep working rather than failing argument parsing. Nothing is forwarded to coana, and the flag is dropped from the reachability documentation. No version bump: this is not being released on its own.
Oskar Haarklou Veileborg (BarrensZeppelin)
requested a review
from a team
as a code owner
September 3, 2026 12:49
|
❌ Version Check Failed Please increment... |
Oskar Haarklou Veileborg (BarrensZeppelin)
requested a review
from Martin Torp (mtorp)
September 3, 2026 12:49
Oskar Haarklou Veileborg (BarrensZeppelin)
requested a review
from Benjamin Barslev Nielsen (barslev)
September 3, 2026 12:51
Benjamin Barslev Nielsen (barslev)
approved these changes
Sep 3, 2026
Oskar Haarklou Veileborg (BarrensZeppelin)
merged commit Sep 3, 2026
6076acf
into
main
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The coana CLI no longer accepts
--lazy-mode, so a reachability run started with--reach-lazy-modefailed on an unrecognized argument.--reach-lazy-modeis kept as a hidden no-op (help=argparse.SUPPRESS), matching how--reach-disable-analysis-splittingwas deprecated in this repo, so pipelines that still pass the flag keep working rather than failing argument parsing. Nothing is forwarded to coana.Changes
socketsecurity/core/tools/reachability.py: drop thelazy_modeparameter, its docstring entry, and the--lazy-modeappend.socketsecurity/socketcli.py: drop thelazy_mode=argument at the call site.socketsecurity/config.py: hide--reach-lazy-modefrom--helpand mark theCliConfigfield deprecated. The field and itsargsdict entry are retained because the argparsedeststill exists, as withreach_disable_analysis_splitting.docs/cli-reference.md: remove the flag from the usage synopsis and the reachability parameter table.Notes
version-check.ymlwill report a failure on this PR. That check is not in main's required status checks; the tradeoff is that this fix will not be published until some later version bump ships.Testing
--reach-lazy-modestill parses (reach_lazy_mode = True) and no longer appears in--help.Note
Low Risk
Backward-compatible CLI deprecation with no coana behavior change beyond removing an invalid argument; reachability invocation path is narrow and low blast radius.
Overview
Fixes reachability runs that failed when pipelines still passed
--reach-lazy-mode, because the coana CLI no longer accepts--lazy-mode.The Socket CLI no longer forwards lazy mode into coana:
lazy_modeis removed fromReachabilityAnalyzer.run_reachability_analysisand from thesocketclicall site, along with the--lazy-modecoana argument.--reach-lazy-moderemains accepted for backward compatibility but is a hidden no-op (argparse.SUPPRESS, same pattern as other deprecated reach flags);CliConfig.reach_lazy_modeis kept so existing configs and scripts do not break on parse. CLI reference docs drop the flag from the usage synopsis and reachability parameter table.Reviewed by Cursor Bugbot for commit 71c2b4d. Configure here.