Skip to content

Stop passing --lazy-mode to the coana CLI - #336

Merged
Oskar Haarklou Veileborg (BarrensZeppelin) merged 2 commits into
mainfrom
oskar/lazy-mode
Sep 3, 2026
Merged

Stop passing --lazy-mode to the coana CLI#336
Oskar Haarklou Veileborg (BarrensZeppelin) merged 2 commits into
mainfrom
oskar/lazy-mode

Conversation

@BarrensZeppelin

@BarrensZeppelin Oskar Haarklou Veileborg (BarrensZeppelin) commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

The coana CLI no longer accepts --lazy-mode, so a reachability run started with --reach-lazy-mode failed on an unrecognized argument.

--reach-lazy-mode is kept as a hidden no-op (help=argparse.SUPPRESS), matching how --reach-disable-analysis-splitting was deprecated in this repo, so pipelines that still pass the flag keep working rather than failing argument parsing. Nothing is forwarded to coana.

Changes

  • socketsecurity/core/tools/reachability.py: drop the lazy_mode parameter, its docstring entry, and the --lazy-mode append.
  • socketsecurity/socketcli.py: drop the lazy_mode= argument at the call site.
  • socketsecurity/config.py: hide --reach-lazy-mode from --help and mark the CliConfig field deprecated. The field and its args dict entry are retained because the argparse dest still exists, as with reach_disable_analysis_splitting.
  • docs/cli-reference.md: remove the flag from the usage synopsis and the reachability parameter table.

Notes

  • No version bump, so version-check.yml will report a failure on this PR. That check is not in main's required status checks; the tradeoff is that this fix will not be published until some later version bump ships.
  • No changelog entry, for the same reason.

Testing

  • --reach-lazy-mode still parses (reach_lazy_mode = True) and no longer appears in --help.
  • Full suite: 523 passed, 2 skipped (both pre-existing GitLab-auth skips).

Note

Low Risk
Backward-compatible CLI deprecation with no coana behavior change beyond removing an invalid argument; reachability invocation path is narrow and low blast radius.

Overview
Fixes reachability runs that failed when pipelines still passed --reach-lazy-mode, because the coana CLI no longer accepts --lazy-mode.

The Socket CLI no longer forwards lazy mode into coana: lazy_mode is removed from ReachabilityAnalyzer.run_reachability_analysis and from the socketcli call site, along with the --lazy-mode coana argument. --reach-lazy-mode remains accepted for backward compatibility but is a hidden no-op (argparse.SUPPRESS, same pattern as other deprecated reach flags); CliConfig.reach_lazy_mode is kept so existing configs and scripts do not break on parse. CLI reference docs drop the flag from the usage synopsis and reachability parameter table.

Reviewed by Cursor Bugbot for commit 71c2b4d. Configure here.

The coana CLI no longer accepts --lazy-mode, so a reachability run started with
--reach-lazy-mode failed on an unrecognized argument.

--reach-lazy-mode is kept as a hidden no-op, matching how
--reach-disable-analysis-splitting was deprecated, so pipelines that still pass
it keep working rather than failing argument parsing. Nothing is forwarded to
coana, and the flag is dropped from the reachability documentation.

No version bump: this is not being released on its own.
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Version Check Failed

Please increment...

@BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) merged commit 6076acf into main Sep 3, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants